Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Enabling Block Scripts redirects twitter to Mobile site. #2884

Closed
srirambv opened this issue Aug 2, 2016 · 16 comments
Closed

Enabling Block Scripts redirects twitter to Mobile site. #2884

srirambv opened this issue Aug 2, 2016 · 16 comments
Assignees
@diracdeltas
Labels
QA/checked-Win64 webcompat
Milestone
0.12.3dev

Comments

@srirambv
Copy link
Collaborator

srirambv commented Aug 2, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Enabling Block Scripts from the shields menu causes twitter to load mobile site.
Disabling Block script still shows the number of blocked script items.
Disabling Shields and opening twitter.com on a new tab still navigates to the mobile site.

Expected behavior:
Should open Desktop version.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64, Windows 7 x64 Professional
  • Brave Version:
    0.11.2 Dev Beta 2
  • Steps to reproduce:
    1. Open twitter.com
    2. Enable Block scripts from the shields menu
    3. After page reloads it redirects to Mobile site
    4. Disable Block scripts from shields menu - still shows the number of scripts blocked
    5. Disable Shields and close tab. Open twitter site in a new tab again navigates to mobile site
    6. Clear History/Cache/Cookie & Site data and then open twitter site still navigates to mobile site.
  • Screenshot if needed:
    image
  • Any related issues:
@luixxiul
Copy link
Contributor

luixxiul commented Aug 2, 2016

I noticed this too

@diracdeltas
Copy link
Member

diracdeltas commented Aug 2, 2016 •
edited
Loading

pretty sure this is due to us running their noscript tag. can hack around it but it's really a problem on Twitter's end, not ours.

@diracdeltas
Copy link
Member

on twitter.com:
screen shot 2016-08-02 at 1 28 55 pm

@diracdeltas diracdeltas added this to the 0.12.3dev milestone Sep 27, 2016
This was referenced Sep 27, 2016
Closed
Closed
Closed
Closed
@srirambv
Copy link
Collaborator Author

Reopening the issue.
Redirect happens to mobile.twitter.com when block-script enabled at page level. If enable block-script at global settings and then opening twitter.com doesn't redirect to mobile.twitter.com.

2884test

@srirambv srirambv reopened this Sep 27, 2016
@diracdeltas
Copy link
Member

i can't repro this on master using the steps above. @srirambv is it happening for you only on the release build?

@srirambv srirambv mentioned this issue Sep 27, 2016
Closed
8 tasks
@srirambv
Copy link
Collaborator Author

@diracdeltas Yes this is happening on the 0.12.3dev-RC1 build.

@bbondy bbondy modified the milestones: 0.12.4dev, 0.12.3dev Sep 28, 2016
@srirambv srirambv mentioned this issue Sep 28, 2016
Closed
@diracdeltas
Copy link
Member

@srirambv @jonathansampson are you still seeing this on 0.12.3 RC3? i downloaded it and still can't repro, either by disabling scripts globally or just on twitter.com

@srirambv
Copy link
Collaborator Author

@diracdeltas this the behavior I see on 0.12.3 RC2 build (clean install)
twitter

@diracdeltas diracdeltas self-assigned this Sep 28, 2016
@diracdeltas
Copy link
Member

i figured out how to repro; should be fixed now

@jonathansampson
Copy link
Collaborator

@diracdeltas That seems to have fixed it; nice work!

@alexwykoff
Copy link
Contributor

@diracdeltas Is the milestone correct? It looks like this is already in master

@diracdeltas
Copy link
Member

@alexwykoff i didn't know if we were making another RC; if so, it's fixed in 0.12.3

@bbondy bbondy modified the milestones: 0.12.3dev, 0.12.4dev Sep 29, 2016
@bbondy
Copy link
Member

bbondy commented Sep 29, 2016

including back in 0.12.3, cherry-picked into dev-channel so it'll be in 0.12.3RC3

bbondy pushed a commit that referenced this issue Sep 29, 2016
@diracdeltas @bbondy
Fix twitter.com redirect to mobile.twitter.com with block scripts
509fbdb 
Fix #2884

Auditors: @srirambv

Test Plan:
1. clean session store
2. go to twitter.com, turn on block scripts
3. twitter.com should not redirect to mobile
@srirambv
Copy link
Collaborator Author

Verified on RC3. Works perfect 👍

@alexwykoff alexwykoff mentioned this issue Sep 29, 2016
Closed
@alexwykoff alexwykoff mentioned this issue Oct 2, 2016
Closed
57 tasks
This was referenced Oct 2, 2016
Closed
Closed
Closed
Closed
@e1ucas
Copy link

e1ucas commented Jan 16, 2018

Can repro the redirect to mobile on MacOS 10.12.6 & Chrome 63.0.3239.132, having javascript Blocked in chrome://settings/content/javascript even with https://twitter.com and https://www.twitter.com as Allowed.

@david0178418
Copy link

david0178418 commented Apr 5, 2018 •
edited
Loading

Can confirm that this has regressed with twitter on v0.22.13 on Mac.

Two notes about my browser state:

  1. I am logged in on twitter
  2. "Block Scripts" is disabled for twitter.com

Steps to reproduce:

  1. Disable "Block Scripts" in preferences
  2. Open https://twitter.com/
    Everything seems to work fine
  3. Enable "Block Scripts" in preferences
  4. Reload twitter tab
    Redirects to mobile site

@diracdeltas diracdeltas mentioned this issue Jul 29, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Win64 webcompat
Projects
None yet
Milestone
0.12.3dev
Development

No branches or pull requests
8 participants
@david0178418 @diracdeltas @jonathansampson @bbondy @alexwykoff @luixxiul @e1ucas @srirambv