This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
URL bar autocomplete mouseover does not interfere with typed URL (fixes #3012) (take 2) #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 17, 2016 01:28
…t does not interfere with typed URL Fixes #3012: Autofill should not happen on URL bar unless item in autocomplete list is clicked
- added test to urlBarSuggestionsTest.js to check that mousing over autocomplete suggestions does not interrupt typing of URL
3 tasks
| @@ -3,7 +3,28 @@ | |||
| * You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| const isDarwin = process.platform === 'darwin' | |||
| module.exports.isForSecondaryAction = (e) => | |||
| module.exports.isForSecondaryAction = (e) => { | |||
There was a problem hiding this comment.
nit for future ref, skip braces when not needed is preferred
|
Wow this feels a lot better, thanks so much for the great work here. |
|
@willy-b great job w/ this! The mouse always got in the way for me, this is a very noticeable fix 😄 |
Merged
This was referenced Aug 21, 2016
This was referenced Aug 23, 2016
This was referenced Aug 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.Fixes #3012: Autofill should not happen on URL bar unless item in autocomplete list is clicked
This replaces the previous PR which was not rebased correctly and lacked a test (PR #3128 )