Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

URL bar autocomplete mouseover does not interfere with typed URL (fixes #3012) #3128

Closed
wants to merge 7 commits into from
Closed

Conversation

willy-b
Copy link
Contributor

@willy-b willy-b commented Aug 11, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits if needed.

Fixes #3012: Autofill should not happen on URL bar unless item in autocomplete list is clicked

Willy Bruns added 4 commits August 11, 2016 10:24
@willy-b willy-b changed the title URL bar autocomplete mouseover does not interfere with typed URL (#3012) URL bar autocomplete mouseover does not interfere with typed URL (fixes #3012) Aug 12, 2016
suggestionList,
selectedIndex
suggestionList: suggestionList,
selectedIndex: selectedIndex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change doesn't seem necessary, any reason for it?

@bbondy
Copy link
Member

bbondy commented Aug 12, 2016

would you mind adding a test for this as well? Thanks.
It could go in here: test/components/navigationBarTest.js
and you could use moveToObject for a the mouse move on top of the suggestions

Willy Bruns added 3 commits August 14, 2016 18:54
- added test to urlBarSuggestionsTest.js to check that mousing over autocomplete suggestions does not interrupt typing of URL
@willy-b
Copy link
Contributor Author

willy-b commented Aug 17, 2016

Thanks @bbondy for all the feedback!
Closing this in favor of a new PR #3225 which is rebased against master and has the changes you requested and a test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants