Autofill - Values are vacated

[alexwykoff]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
The autofill values have suddenly and mysteriously been vacated.

Expected behavior:
The autofill values should persist until intentionally deleted.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Tested on Ubuntu. I believe it is isolated to Linux, but not 100% sure.
• Brave Version:
  0.11.6 pre-beta5
• Steps to reproduce:
  1. Create autofill values.
  2. ???
• Screenshot if needed:
  
• Any related issues:

[darkdh]

Did you remove ~/Library/Application Support/brave/Web Data manually?
This will happen when you remove the database(Web Data) and the session data still keeps the guid of the entries.

[alexwykoff]

I was able to repro the issue that way, however, that was not the action I took originally.

We can move this out of the milestone / close it as DNR.

[bbondy]

Sounds like we need to find STR that doesn't involve clearing data, can you try to get them before closing this out @alexwykoff ?

[alexwykoff]

I've fiddled with this quite a bit and cannot repro. It's a mystery.

Closing DNR

[alexwykoff]

Finally found the STR:

1. Create autofill values in a prior version (ex 0.11.6 beta6)
2. Leave about:autofill open, quit Brave
3. Open a newer version (ex RC1), about:autofill should open automatically

[alexwykoff]

Actually the STR are simpler:

1. Create autofill values in a prior version (ex 0.11.6 beta6)
2. Quit and reopen Brave
3. Check about:autofill

[alexwykoff]

[bbondy]

prior version also means RC1 right?

[darkdh]

STR on master with latest electron

1. rm ~/Library/Application Support/brave
2. npm start
3. The database cannot be initialized error on console
4. Any autofill changes cannot be write into disk

[darkdh]

Thanks to @bridiver ,the database initialized problem is fixed by brave/muon@18496a4.
I will add a PR for deleting non-existed entry automatically

[darkdh]

QA verify steps

• Test folder creation (brave/muon@18496a4)

1. Remove ~/Library/Application Support/brave
2. Launch brave
3. Add autofill data
4. Quit brave and relaunch it
5. The autofill data should exist

• Test automatically remove invalid data entry (Automatically delete invalid entry from appStore #3598)
  1. Add autofill data
  2. Quit brave
  3. Remove ~/Library/Application Support/brave/Web Data
  4. Launch brave
  5. The autofill data added shouldn't exist

[bbondy]

Fix is in brave/electron 1.3.8 also make sure electron version appears as such in about when testing. Also see Anthony's steps to test above.