Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

overflowIndicator not appearing on bookmark toolbar if show only favicon option is enabled #3525

Closed
luixxiul opened this issue Aug 29, 2016 · 11 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 29, 2016

Describe the issue you encountered: overflowIndicator does not appear on the bookmark toolbar, if show only favicon option is enabled.

Expected behavior: overflowIndicator should appear.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32 bit
  • Brave Version: 0.11.6 Beta6
  • Screenshot if needed:
    clipboard01
    clipboard02

There are other favicons and folder icons next to the folder named "tempfolder" (which is omitted here).

Setting a milestone for now.

@luixxiul luixxiul added this to the 0.11.6dev milestone Aug 29, 2016
@bbondy bbondy self-assigned this Aug 30, 2016
@bradleyrichter
Copy link
Contributor

@bbondy can you make the folder icon smaller and dark grey while you are in there?

@bbondy bbondy removed this from the 0.11.6dev milestone Aug 30, 2016
@bbondy
Copy link
Member

bbondy commented Aug 30, 2016

@luixxiul you mentioned Brave Version: 0.11.5 Beta6, do you mean 0.11.6beta6?
Is this also an issue in 0.11.5?

@luixxiul
Copy link
Contributor Author

sorry, my mistake. I mean 0.11.6 beta6.

@bbondy bbondy added this to the 0.11.6dev milestone Aug 30, 2016
@bbondy bbondy closed this as completed in 8f585cc Aug 30, 2016
@bbondy
Copy link
Member

bbondy commented Aug 30, 2016

@bbondy can you make the folder icon smaller and dark grey while you are in there?

That should be done now too, used @darkgray

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 31, 2016

On Windows7 the indicator can be clipped (the right bar is a window border).

clipboard01

@luixxiul luixxiul reopened this Aug 31, 2016
@bbondy bbondy removed this from the 0.11.6dev milestone Aug 31, 2016
@bbondy
Copy link
Member

bbondy commented Aug 31, 2016

Should be a lot better than what it was at least, but what is the blue bar in the screenshot on the right?

I'm k with this being re-opened but I'm going to kick it out of 0.11.6 because it is not all cases and probably specific to types of bookmarks or something else.

@bbondy
Copy link
Member

bbondy commented Aug 31, 2016

Windows border I guess? I think maybe the part that is unhandled is accounting only for the content width and not the window width..

@luixxiul
Copy link
Contributor Author

yes it's the window border.

@bbondy bbondy added this to the 0.11.6dev milestone Aug 31, 2016
@bbondy
Copy link
Member

bbondy commented Aug 31, 2016

since we're doing rc2 I'll get another fix for the border

@bbondy
Copy link
Member

bbondy commented Aug 31, 2016

clearing testing labels so this will be re-tested.

@bbondy
Copy link
Member

bbondy commented Aug 31, 2016

See test plan in both commits for testing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants