Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

overflow indicator on bookmarks toolbar is sometimes hidden #6869

Closed
luixxiul opened this issue Jan 26, 2017 · 10 comments
Closed

overflow indicator on bookmarks toolbar is sometimes hidden #6869

luixxiul opened this issue Jan 26, 2017 · 10 comments
Labels
bug feature/bookmarks fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. misc/favicon priority/P3 Major loss of function. regression wontfix

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jan 26, 2017 •
edited
Loading

Describe the issue you encountered:
@luixxiul luixxiul added this to the 0.13.1 milestone Jan 26, 2017
@srirambv
Copy link
Collaborator

srirambv commented Jan 27, 2017 •
edited
Loading

Overflow indicator is not shown at all when show favicon only is selected its completely hidden. Reimporting the same file puts the folders at the end which shows up the overflow indicator and then behavior changes as reported in issue

Additional QA Steps.
1. Do a clean install of 0.13.0 RC9
2. Import large amount of bookmarks so that overflow indicator is shown
3. Set Text only in settings for bookmark toolbar, overflow indicator is shown
4. Set Text and Favicon for bookmark toolbar, overflow indicator is still shown
5. Set Favicon only for bookmark toolbar, No overflow indicator is shown
6. Reimport the same html file, indicator is shown

overflow

@luixxiul
Copy link
Contributor Author

luixxiul commented Jan 28, 2017 •
edited
Loading

Yes I confirm it on Windows 10 64 bit

This seems to be the same issue @bbondy has solved here: #3525

@bbondy bbondy modified the milestones: 0.13.3, 0.13.2 Jan 31, 2017
@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
This was referenced Jun 18, 2017
Closed
Closed
GreenRecycleBin added a commit to GreenRecycleBin/browser-laptop that referenced this issue Jun 25, 2017
@GreenRecycleBin
Always show the overflow indicator
398a3cc 
On the bookmarks toolbar.

Fix brave#6869.

However, there is now too much space before the overflow indicator.

I'm not well-versed with CSS so I'd appreciate some pointers.
Auditors:

Test Plan:
GreenRecycleBin added a commit to GreenRecycleBin/browser-laptop that referenced this issue Jul 14, 2017
@GreenRecycleBin
Always show the overflow indicator on the bookmark toolbar
e6d5d02 
Fix brave#6869.
GreenRecycleBin added a commit to GreenRecycleBin/browser-laptop that referenced this issue Jul 14, 2017
@GreenRecycleBin
Always show the overflow indicator on the bookmark toolbar
273f01f 
Fix brave#6869.
GreenRecycleBin added a commit to GreenRecycleBin/browser-laptop that referenced this issue Jul 18, 2017
@GreenRecycleBin
Always show the overflow indicator on the bookmark toolbar
f291eb3 
Fix brave#6869.
@cezaraugusto cezaraugusto added this to the 0.20.x (Nightly Channel) milestone Jul 25, 2017
@GreenRecycleBin GreenRecycleBin mentioned this issue Jul 25, 2017
Merged
8 tasks
@srirambv
Copy link
Collaborator

@bsclifton can this be pulled into 0.18.x? I see this happening on the latest build and its quite annoying to resize the browser everytime just to get the overflow indicator

@bsclifton bsclifton marked this as a duplicate of #9547 Jul 26, 2017
@srirambv
Copy link
Collaborator

srirambv commented Aug 9, 2017 •
edited
Loading

On a side note, when you have pinned tabs and then switch to one of the pinned tabs, pressing tab 3 times causes this
image
The first two pinned tabs goes out of view and the only option to restore back to normal is to maximize the window and restore.

This behaviour seen on 0.18.15 on Win x64

@NejcZdovc NejcZdovc mentioned this issue Aug 10, 2017
Closed
@srirambv srirambv mentioned this issue Oct 12, 2017
Closed
@luixxiul
Copy link
Contributor Author

luixxiul commented Nov 6, 2017

For me this issue is still not solved. @srirambv would you mind checking it on Windows?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Nov 6, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Nov 6, 2017

#11507 (comment)

After bookmarking other sites except about pages and editing some of them, the indicator started appearing. I'll search for concrete steps to reproduce the issue.

@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Nov 6, 2017
@srirambv
Copy link
Collaborator

srirambv commented Nov 6, 2017 •
edited
Loading

Confirmed #6869 (comment) still happens on the latest build with a pinned tab.

This is on the 0.19.80
image

By default the overflow indicator is missing with bookmarks
image

@srirambv srirambv reopened this Nov 6, 2017
@srirambv
Copy link
Collaborator

srirambv commented Nov 6, 2017

#11507 (comment) doesnt make a difference on Windows. No overflow indicator shown

@cezaraugusto
Copy link
Contributor

I'm taking this, please ping me first before changing the assignment. The IntObs API might solve this definitely and is already introduced in this release for tabs.

@cezaraugusto cezaraugusto self-assigned this Nov 6, 2017
@alexwykoff
Copy link
Contributor

Commentary from Kamil, this is still a thing.

@alexwykoff alexwykoff added the priority/P3 Major loss of function. label Nov 29, 2017
@alexwykoff alexwykoff modified the milestones: 0.20.x (Beta Channel), Backlog (Prioritized) Nov 29, 2017
@cezaraugusto cezaraugusto removed their assignment Jul 30, 2018
@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Aug 26, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Aug 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug feature/bookmarks fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. misc/favicon priority/P3 Major loss of function. regression wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @srirambv