Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Cmd+T (New Tab) shortcut becomes disabled while navigation occurs #3782

Closed
gulkily opened this issue Sep 7, 2016 · 3 comments · Fixed by #3813
Closed

Cmd+T (New Tab) shortcut becomes disabled while navigation occurs #3782

gulkily opened this issue Sep 7, 2016 · 3 comments · Fixed by #3813

Comments

@gulkily
Copy link

gulkily commented Sep 7, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
While navigating from one GitHub page to another, the Cmd+T shortcut (New Tab) is ignored.

Expected behavior:
The shortcut should always be available, regardless of current state

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS
  • Brave Version: 0.12.0
  • Steps to reproduce:
    1. Open a GitHub listing page, e.g. https://github.com/brave/browser-laptop
    2. Click one of the files, e.g. LICENSE.txt
    3. Quickly, while the loading is still happening, press Cmd+T. I can reproduce the bug consistently if I press Cmd+T as quickly as I can after clicking the link.
@bbondy
Copy link
Member

bbondy commented Sep 7, 2016

@bridiver I think this will be fixed with your menu fix?

@bridiver
Copy link
Collaborator

bridiver commented Sep 7, 2016

I think so. I have seen similar issues with keyboard shortcuts and I can't replicate this one or the others with the menu fix

@bbondy
Copy link
Member

bbondy commented Sep 8, 2016

I will mark this as fixed in 0.12.1 and it can be tested / re-opened if not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants