Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

password notification bar is not aligned well #3920

Closed
luixxiul opened this issue Sep 12, 2016 · 1 comment
Closed

password notification bar is not aligned well #3920

luixxiul opened this issue Sep 12, 2016 · 1 comment
Assignees
@ayumi
Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-Win32 QA/checked-Win64
Milestone
0.12.1dev

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: password notification bar is not aligned well (on Japanese setting)

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.1
  • Steps to reproduce:
    1. Delete your trac.torproject.org password
    2. Go to https://trac.torproject.org/projects/tor/login
    3. Log in
  • Screenshot if needed:
    clipboard01
  • Any related issues:
@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label Sep 12, 2016
@luixxiul luixxiul mentioned this issue Sep 12, 2016
Closed
@luixxiul luixxiul added this to the 0.12.1dev milestone Sep 12, 2016
@luixxiul
Copy link
Contributor Author

Setting a milestone for now.

ayumi added a commit that referenced this issue Sep 12, 2016
@ayumi
Fix overflowing notification buttons
936f782 
Fix #3920

Auditors: @luixxiul @jkup

Test Plan:

1. Open Brave and trigger a notification e.g. visit https://www.browserleaks.com/geo
2. Horizontally resize window so the notification text overflows
3. Confirm that the buttons don't overflow out of the notification
@ayumi ayumi mentioned this issue Sep 12, 2016
Merged
4 tasks
@ayumi ayumi mentioned this issue Sep 13, 2016
Closed
This was referenced Sep 14, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Sep 15, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ayumi ayumi

Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.1dev
Development

No branches or pull requests
4 participants
@ayumi @alexwykoff @luixxiul @srirambv