Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Line should always appear when user scroll down #4085

Closed
wants to merge 1 commit into from

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Sep 17, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #3888

Auditors: @bradleyrichter @diracdeltas @bbondy

Test Plan:

If you have enough publishers to cause a scroll, the headers (Rank, site, Include, etc) should remain fixed to the top)

This is the only way I could figure out getting it to work without JavaScript. It's kind of ugly. Let me know if the code is worth the feature or if any of you know a better way!

@jkup jkup added this to the 0.12.2dev milestone Sep 17, 2016
@jkup jkup added the design A design change, especially one which needs input from the design team. label Sep 17, 2016
@diracdeltas
Copy link
Member

could you please rebase this?

@jkup jkup modified the milestones: 0.12.3dev, 0.12.2dev Sep 19, 2016
@jkup
Copy link
Contributor Author

jkup commented Sep 19, 2016

Realizing while rebasing this isn't exactly what we want. We want only this one particular table to be fixed headers, not all sortable tables. Since this doesn't seem pressing for 0.12.2 -- is it cool if I just bump this to 0.12.3 and grab it this week? + @bbondy @diracdeltas

@diracdeltas
Copy link
Member

i'm ok with bumping this

@jkup
Copy link
Contributor Author

jkup commented Sep 26, 2016

Closing for now, will open a new PR with the new approach.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. QA/no-qa-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave payments: Line should always appear when user scroll down
4 participants