Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

site-specific Bravery settings headers should disappear when the list is empty #4319

Closed
srirambv opened this issue Sep 27, 2016 · 2 comments
Closed

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?

Describe the issue you encountered:
HTTPSE is not shown under site-specific Bravery settings. Only comes up when HTTPSE is disabled on a site and when the site specific setting is deleted, HTTPSE doesn't show under the site specific settings

Expected behavior:
Should always shows the label under Bravery settings similar to the other ones

@srirambv srirambv added this to the 0.12.3dev milestone Sep 27, 2016
@bbondy bbondy removed this from the 0.12.3dev milestone Sep 27, 2016
@diracdeltas
Copy link
Member

They should actually all disappear from the list when empty

@diracdeltas diracdeltas self-assigned this Sep 27, 2016
@diracdeltas diracdeltas changed the title HTTPSE is not shown under site-specific Bravery settings site-specific Bravery settings headers should disappear when the list is empty Sep 27, 2016
@diracdeltas diracdeltas added this to the 0.12.4dev milestone Sep 28, 2016
@bbondy bbondy modified the milestones: 0.12.3dev, 0.12.4dev Sep 29, 2016
@bbondy
Copy link
Member

bbondy commented Sep 29, 2016

Included in 0.12.3RC3

bbondy pushed a commit that referenced this issue Sep 29, 2016
Fix #4319

Auditors: @srirambv

Test Plan:
1. clean session store. go to apple.com and lower shields
2. verify that apple.com shows up in about:preferences#shields
3. raise shields on apple.com
4. verify that 'All Brave Shields' header is no longer in about:preferences#shields
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants