Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Addfunds dialog needs a little margin #5799

Closed
mrose17 opened this issue Nov 22, 2016 · 5 comments · Fixed by #6047
Closed

Addfunds dialog needs a little margin #5799

mrose17 opened this issue Nov 22, 2016 · 5 comments · Fixed by #6047
Assignees
@luixxiul
Labels
feature/rewards QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@mrose17
Copy link
Member

mrose17 commented Nov 22, 2016

as noted in #5797 (comment)

446c2cfc-b0b5-11e6-83b1-9949cbecbcd3
@mrose17 mrose17 added this to the 0.13.2 milestone Nov 22, 2016
@luixxiul luixxiul mentioned this issue Nov 23, 2016
Closed
@luixxiul
Copy link
Contributor

working on it

screenshot 2016-11-23 11 19 47

@luixxiul luixxiul mentioned this issue Nov 23, 2016
Closed
@luixxiul luixxiul mentioned this issue Dec 4, 2016
Merged
4 tasks
@bsclifton
Copy link
Member

@luixxiul was this addressed with #6009?

@luixxiul
Copy link
Contributor

luixxiul commented Dec 6, 2016

@bsclifton No, I will fix this in the next PR (part 2).

@luixxiul luixxiul modified the milestones: 0.13.1, 0.13.2 Dec 7, 2016
@luixxiul
Copy link
Contributor

luixxiul commented Dec 8, 2016

The fix will be like these:

For US
screenshot 2016-12-08 23 29 36

For non-US
screenshot 2016-12-08 23 06 17

With .pull-right the button is misaligned.
screenshot 2016-12-08 23 34 39

@luixxiul luixxiul mentioned this issue Dec 15, 2016
Merged
4 tasks
@luixxiul luixxiul modified the milestones: 0.13.0, 0.13.1 Dec 15, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor

Test plan:

Open about:preferences#payments
Click "Add funds"
Make sure the buttons on the footer are aligned like this: #5799 (comment)

@luixxiul luixxiul mentioned this issue Jan 20, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/rewards QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Refactor about:preferences#payments followups
4 participants
@mrose17 @luixxiul @bsclifton @srirambv