Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Buttons inside #navigator are not working #6253

Closed
srirambv opened this issue Dec 16, 2016 · 8 comments · Fixed by #6681
Closed

Buttons inside #navigator are not working #6253

srirambv opened this issue Dec 16, 2016 · 8 comments · Fixed by #6681

Comments

@srirambv
Copy link
Collaborator

srirambv commented Dec 16, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Refresh/Home buttons are not working

Expected behavior:
Refresh/Home buttons should work

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version:
    0.13.0 Preview 4

  • Steps to reproduce:

    1. Do a clean install of 0.13.0
    2. Open a newtab/visit a page
    3. Hover over Refresh/Home button, hoverbox is not shown, clicking on both button doesn't work
  • Screenshot if needed:
    123 convert-video-online com

  • Any related issues:

    cc: @bsclifton

@luixxiul
Copy link
Contributor

luixxiul commented Dec 16, 2016

NoScript button is unclickable too.

Also it worked until the latest preview.

@luixxiul luixxiul changed the title Refresh/Home buttons are not working Buttons inside #navigator are not working Dec 16, 2016
@srirambv srirambv added this to the 0.13.0 milestone Dec 16, 2016
@luixxiul
Copy link
Contributor

luixxiul commented Dec 16, 2016

The buttons starts working after showing the menu pulldown on the menubar. #6236

@srirambv
Copy link
Collaborator Author

It works only when the browser is in focus. If the focus is lost the buttons don't work again. Have to bring down th menu to enable them

@luixxiul
Copy link
Contributor

If the focus is lost the buttons don't work again.

Though I'm not sure completely what you meant, the reload button works after the focus is lost and regained.

reload

@srirambv
Copy link
Collaborator Author

It works on that particular tab on when the menu is pulled down. If you switch to another tab the buttons become inactive. If you go back to the previous tab it still doesn't show the
6253

@bsclifton
Copy link
Member

I confirmed this is 100% still an issue- excellent find

@luixxiul
Copy link
Contributor

luixxiul commented Jan 16, 2017

Reopening as I found the root cause of this:
19360c1#diff-02c4b23ad267fe636760179e32fa29ceR842

I will create a PR to fix this and #6680

@luixxiul
Copy link
Contributor

Test plan: #6681 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.