Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Menu on macOS is unusable during sync #7307

Closed
bsclifton opened this issue Feb 17, 2017 · 2 comments
Closed

Menu on macOS is unusable during sync #7307

bsclifton opened this issue Feb 17, 2017 · 2 comments

Comments

@bsclifton
Copy link
Member

bsclifton commented Feb 17, 2017

Test plan

fcb4fc5


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When sync is happening, the menu will rebuild itself (since new items are being added). Under the hood, it's destroying and re-creating the menu. This is

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    0.13.5 preview 1

  • Steps to reproduce:

    1. Be part of a sync group
    2. Have someone entries (one every few seconds)
    3. Try to use the menu; you'll notice you can click then the menu auto closes itself
  • Actual result:
    Menu closes itself often. You can click again, see the new items, then if another item comes in, it'll close itself.

  • Expected result:
    Menu should not close itself; it should at least show what was there

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?
    no - 0.13.5 preview 1

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@bsclifton bsclifton added this to the 0.13.5 milestone Feb 17, 2017
@diracdeltas
Copy link
Member

probably will be addressed by #7308

diracdeltas added a commit that referenced this issue Feb 24, 2017
fix #7308
fix #7293
fix #7307

Auditors: @ayumi @alexwykoff

Test Plan:
1. in about:preferences#sync, choose the 'i have an existing sync code' option. enter in the code words that Alex posted in #testers (starts with 'forsaken')
2. wait for 6000+ bookmarks to appear in the bookmarks toolbar. the browser should not freeze or use excessive memory during the sync. for me it takes about 5 seconds.
3. open about:bookmarks. you should see a bunch of folders with bookmarks, including subfolders.
@alexwykoff
Copy link
Contributor

I don't think we've entirely cracked the nut on this one. I still get a lockup when joining the 'forsaken...' sync group.

2017-03-03 01-03-01.mp4.zip

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants