Allow user to pin their favorite sites in Brave Payments (and other UI tweaks)

[bradleyrichter]

Automated test plan

• npm run test -- --grep="LedgerTable"
• npm run test -- --grep="Ledger table"

Test plan

• features specified in Allow user to pin their favorite sites in Brave Payments (and other UI tweaks) #7347

Original issue description

Item 1: Update column headers to match this config. The rank number column has been removed, and an actions column has been added.

Item 2: Create a new grouped column for action buttons. The delete button moves here, and "Pin site" will be added. Eventually, a tweet button may be added.

Item 3: The percent column needs to support an edit box with active and inactive states.

Item 4: Add ability to show permanent positioned items by adding sort hierarchy. This will allow sorting by "pinned state" and then column.

[NejcZdovc]

@bradleyrichter
User will be able to set percentage only for pinned publishers?

How will the user set default value again? Just delete everything in the input and press enter/unselect and default value will be inserted?

[NejcZdovc]

When user deletes one publisher, how can he retrieve it back?
I noticed that include is disabled when item is pinned, so user can't toggle it when publisher is pinned?
@bradleyrichter

[mrose17]

if you remove a publisher (e.g., click under the "Remove" column -or- right-click for "Never include this site...") you can re-enable the publisher by going to shields and removing the blocking entry there.

note that this won't recover the previous history ... that's gone forever, by design. it will allow the publisher to be considered going forward.

[NejcZdovc]

@mrose17 @bradleyrichter I am testing the current version I noticed that when you exclude one site, this site still have percentage. Shouldn't excluded site percentage be set to 0 and percentages for other sites be recalculated?

[bradleyrichter]

The percentage is tied to the usage data but now we must change it to mean "percentage of funds" for this UI to work and make sense. This is the same case if/when we use sliders.

…

On Mar 10, 2017, at 5:51 AM, Nejc Zdovc ***@***.***> wrote: @mrose17 @bradleyrichter I am testing the current version I noticed that when you exclude one site, this site still have percentage. Shouldn't excluded site percentage be set to 0 and percentages for other sites be recalculated? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[NejcZdovc]

@bradleyrichter Ok, so I need to change this as well I guess. Will do

[bsclifton]

@NejcZdovc could you post the steps to test in the original post here? Thanks 😄

[luixxiul]

@NejcZdovc with the commit you closed the issue you deleted minimumPercentage and I am not sure why.

3515e99#diff-6e336f58ebfb0aaf5268c68f492d5c9cL64

[NejcZdovc]

@luixxiul because we added show all button instead

[luixxiul]

and we cannot hide 0 % sites once you push the button as we don't have the hide button

which is by design?

[luixxiul]

As a result of that:

If it is by design, let's add bulk remove function

[NejcZdovc]

Let's continue the discussion in #9137