Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed remember password prompt accidentally displaying password in notification for certain sites #7649

Closed
bbondy opened this issue Mar 10, 2017 · 2 comments · Fixed by #7653
Closed

Fixed remember password prompt accidentally displaying password in notification for certain sites #7649

bbondy opened this issue Mar 10, 2017 · 2 comments · Fixed by #7653
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.14.0

Comments

@bbondy
Copy link
Member

bbondy commented Mar 10, 2017 •
edited by luixxiul
Loading

Test plan

#7653 (comment)

Posting for a friend:
When changing a password on a website that offers three input fields (Old Password, New Password and Re-type Password), Brave seems to mistake one of the fields as a username and displays the password in the notification rather than the user name... I've seen this happen several times.

STR (attached a screenshot as an example):
login into Ebay and change your password

cc @diracdeltas would you mind taking this?
@bbondy bbondy changed the title remember password prompt remember password prompt uses password as username Mar 10, 2017
@bbondy bbondy added this to the 0.13.6 milestone Mar 10, 2017
@bbondy
Copy link
Member Author

bbondy commented Mar 10, 2017

screenshot 2017-03-10 06 36 41

@diracdeltas
Copy link
Member

i can't repro this on https://reg.ebay.com/reg/ChangePwd so another example would be helpful if anyone has one

diracdeltas added a commit that referenced this issue Mar 11, 2017
@diracdeltas
do not accidentally show password as username
56537e5 
fix #7649

Test Plan:
1. automated tests for notificationBar should pass
2. changing the password on https://reg.ebay.com/reg/ChangePwd and clicking 'submit' should not show the current password in the notification bar
@diracdeltas diracdeltas mentioned this issue Mar 11, 2017
Merged
4 tasks
This was referenced Mar 14, 2017
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 17, 2017
Closed
Closed
@alexwykoff alexwykoff changed the title remember password prompt uses password as username Fixed remember password prompt accidentally displaying password in notification for certain sites Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

do not accidentally show password as username brave/browser-laptop
5 participants
@diracdeltas @bbondy @alexwykoff @luixxiul @srirambv