Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed submenu position for bookmarks #7662

Closed
NejcZdovc opened this issue Mar 12, 2017 · 0 comments
Closed

Fixed submenu position for bookmarks #7662

NejcZdovc opened this issue Mar 12, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
bug feature/context-menu OS/Windows QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 12, 2017 •
edited by luixxiul
Loading

Test plan

#7661 (comment)

  1. Launch Brave on Windows
  2. Visit Preferences, disable Hide the menu bar by default, and confirm the menu shows up
  3. Add 10 bookmark folders to your bookmarks toolbar (ex: name them 1, 2, 3, etc)
  4. For the very last folder (ex: 10), add a subfolder such as 1010
  5. Make the window's height small enough that it causes an overflow to happen
  6. Click the bookmarks menu (or open using keyboard, either way) and use mouse hover to open the 10 folder
  7. Confirm the Y position of the subitem (1010) matches the Y of the parent (10)

Original issue description

  • Did you search for similar issues before submitting this one?
    similar Fixed right click not dismissing / hiding an open menu (Windows only) #7403

  • Describe the issue you encountered:
    Second level context menu is not positioned correctly

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows, macOS (with forced windows menu)

  • Brave Version (revision SHA):
    3ad0f41

  • Steps to reproduce:

    1. add so many items to the bookmark root folder to get scrollbar when going to the windows menu
    2. add folder to the bookmark root folder with 3 levels

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    yes

  • Can this issue be consistently reproduced?
    yes

  • Screenshot if needed:
    5
@NejcZdovc NejcZdovc added this to the 0.13.6 milestone Mar 12, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 12, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 12, 2017
@NejcZdovc
Removes unnecessary width/height
33c3b2c 
Resolves brave#7403 brave#7662

Auditors: @bsclifton

Test Plan:
- specified in the issue brave#7403
@NejcZdovc NejcZdovc mentioned this issue Mar 12, 2017
Merged
4 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 12, 2017
@NejcZdovc
Removes unnecessary width/height
7d1791c 
Resolves brave#7403 brave#7662

Auditors: @bsclifton

Test Plan:
- specified in the issue brave#7403
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 12, 2017
@NejcZdovc
Removes unnecessary width/height
aa6adeb 
Resolves brave#7403 brave#7662

Auditors: @bsclifton

Test Plan:
- specified in the issue brave#7403
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 13, 2017
@NejcZdovc
Removes unnecessary width/height
0628135 
Resolves brave#7403 brave#7662 brave#1589

Auditors: @bsclifton

Test Plan:
- specified in the issue brave#7403
@bsclifton bsclifton modified the milestones: 0.13.7, 0.13.6 Mar 13, 2017
@bsclifton bsclifton changed the title Second level context menu Y position of second level (or higher) folders is wrong Mar 17, 2017
@bsclifton bsclifton changed the title Y position of second level (or higher) folders is wrong Y position of second level (or higher) folders is wrong in Windows bookmark menu Mar 17, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 26, 2017
@NejcZdovc
Removes unnecessary width/height
0e0e374 
Resolves brave#7403 brave#7662 brave#1589

Auditors: @bsclifton

Test Plan:
- specified in the issue brave#7403
@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
@bsclifton bsclifton changed the title Y position of second level (or higher) folders is wrong in Windows bookmark menu Fixed wrong Y position in second level (or higher) folders in bookmark menu (when having many entries) Apr 14, 2017
This was referenced Apr 17, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title Fixed wrong Y position in second level (or higher) folders in bookmark menu (when having many entries) Fixed submenu position for bookmarks Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/context-menu OS/Windows QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
6 participants
@alexwykoff @luixxiul @cezaraugusto @bsclifton @NejcZdovc @srirambv