Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Downloading the same name file disabling the save file dialog should change the filename #7764

Closed
luixxiul opened this issue Mar 17, 2017 · 5 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Mar 17, 2017

Test plan

#9867 (comment)


Describe the issue you encountered:
Downloading the same name file disabling the save file dialog should change the filename, like Edge does. For now the file is overwritten, which users do not always want to see.

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version (revision SHA): 0.14.0 Preview

  • Steps to reproduce:

    1. Open about:preferences
    2. Specify a download path
    3. Disable "Always ask me where to save files"
    4. Download a file of a release from https://github.com/brave/browser-laptop/releases (eg RELEASES-ia32 of the Preview3)
    5. Wait until the download ends
    6. Download another file which has the same name of a different version (eg RELEASES-ia32 of the Preview2)
  • Actual result: the file is overwritten

  • Expected result: the file should be saved with the filename changed, eg RELEASES-ia32(1)

  • Any related issues: Added "Save my downloads here" setting #2110

Marking this with impact/high as the users could lose their files by accident because of this setting, which behaves slightly different than the other browsers.

@NejcZdovc
Copy link
Contributor

I think that this should be handled on Muon part

cc @bridiver

@NejcZdovc NejcZdovc assigned bridiver, bsclifton and darkdh and unassigned NejcZdovc Mar 26, 2017
@kosta
Copy link

kosta commented Apr 23, 2017

I ran into this today. Please fix! This bug scares me.

@luixxiul luixxiul added this to the 1.0.1 milestone May 29, 2017
@eljuno
Copy link
Contributor

eljuno commented Jun 22, 2017

+1 from community

@timborden
Copy link
Contributor

timborden commented Jul 5, 2017

Hey @luixxiul & @NejcZdovc, I just submitted a PR (#9867) for this issue

@NejcZdovc NejcZdovc modified the milestones: 0.20.x (Nightly Channel), 1.0.1 Jul 5, 2017
timborden added a commit to timborden/browser-laptop that referenced this issue Jul 5, 2017
timborden added a commit to timborden/browser-laptop that referenced this issue Jul 6, 2017
timborden added a commit to timborden/browser-laptop that referenced this issue Jul 11, 2017
timborden added a commit to timborden/browser-laptop that referenced this issue Jul 11, 2017
@timborden
Copy link
Contributor

Hey @luixxiul & @NejcZdovc, I've updated the PR based on the feedback from @bridiver and added some tests as well....FYI

@luixxiul luixxiul modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 7, 2017
timborden added a commit to timborden/browser-laptop that referenced this issue Aug 9, 2017
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@bbondy bbondy removed this from the 0.21.x (Developer Channel) milestone Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.