Blank tabs bar appears after increasing the number of tabs per tab set

[luixxiul]

Test plan

#9773 (comment)

---

Describe the issue you encountered:
the tabs bar becomes blank after increasing the number of tabs per tab set under a condition. I believe the same kind of issue had been fixed once and then regressed, recently or not.

• Platform (Win7, 8, 10? macOS? Linux distro?):

• Brave Version (revision SHA): 64b381a

• Steps to reproduce:

  1. Open about:preferences#tabs
  2. Set the number of tabs per tab set to 6
  3. Open new tabs to create a new tab set, which has just 2 tabs
  4. Increase the number to 8

• Actual result: the blank tabs bar which has zero tabs appears

• Expected result: the 2nd tab set should be closed

• Any related issues:

[cezaraugusto]

can't repro per str, can you confirm?

[bsclifton]

@luixxiul is this still an issue? I'll close and assign to 0.17.x so we can retest

[srirambv]

This is still reproducible if the 8th tab opened is preferences and change the tabset count to 8 then you get the empty tabs bar

This is been a known issue when you have tabsets and if you close the single tab in a new set it shows empty tabs bar. And the behavior is still same even if you have pinned tabs

[NejcZdovc]

@bsclifton I created a fix for this one, so if we want to pull this into 0.18, please change milestone for this issue and connected PR

[luixxiul]

should we pull the issue to 0.18 if the fix works?

[bsclifton]

Pulling into 0.18.x sounds great (if the fix works and there are sufficient tests) 😄

[NejcZdovc]

I am trying to add test, but context is messing with me 😄