Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Block phishing/malware not working #7916

Closed
srirambv opened this issue Mar 27, 2017 · 0 comments · Fixed by #7924
Closed

Block phishing/malware not working #7916

srirambv opened this issue Mar 27, 2017 · 0 comments · Fixed by #7924
Assignees
@darkdh
Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.14.0

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Block phishing/malware not working

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.14.0
    rev 61b6b6b
    Issue from preview 5(cr57) onward

  • Steps to reproduce:

    1. Do a clean install of 0.14.0 Preview 7
    2. Visit http://downloadme.org
    3. Site is not blocked

  • Actual result:
    Block phishing/malware not working, site downloadme.org is not getting blocked

  • Expected result:
    Block phishing/malware should block blacklisted sites

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    phising

  • Any related issues:
    cc: @bbondy
@srirambv srirambv added this to the 0.14.0 milestone Mar 27, 2017
@darkdh darkdh self-assigned this Mar 27, 2017
@darkdh darkdh removed the OS/Windows label Mar 27, 2017
darkdh added a commit to darkdh/browser-laptop that referenced this issue Mar 27, 2017
@darkdh
Only check third party url when not in main frame
fc24493 
fix brave#7916

Auditors: @bbondy, @bsclifton

Test Plan:
- Make sure automated tests are passing
  - `npm run test -- --grep=adBlockUtil`
- Make sure you don't see ads on YouTube.
- Make sure `http://downloadme.org/` will be reported as malicious site
@darkdh darkdh mentioned this issue Mar 27, 2017
Merged
4 tasks
bsclifton pushed a commit that referenced this issue Mar 28, 2017
@darkdh @bsclifton
Only check third party url when not in main frame
d71ea08 
fix #7916

Auditors: @bbondy, @bsclifton

Test Plan:
- Make sure automated tests are passing
  - `npm run test -- --grep=adBlockUtil`
- Make sure you don't see ads on YouTube.
- Make sure `http://downloadme.org/` will be reported as malicious site
This was referenced Mar 28, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Mar 30, 2017
Closed
bridiver pushed a commit that referenced this issue Apr 4, 2017
@darkdh @bridiver
Only check third party url when not in main frame
ece3db6 
fix #7916

Auditors: @bbondy, @bsclifton

Test Plan:
- Make sure automated tests are passing
  - `npm run test -- --grep=adBlockUtil`
- Make sure you don't see ads on YouTube.
- Make sure `http://downloadme.org/` will be reported as malicious site
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Only check third party url when not in main frame darkdh/browser-laptop
4 participants
@alexwykoff @luixxiul @darkdh @srirambv