This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactor siteInfo.js with Aphrodite #7949
Assignees
Labels
Milestone
Comments
bridiver
pushed a commit
that referenced
this issue
Apr 6, 2017
Closes #7949 Also modify messageBox.js, which was introduced with #7107 - Introduced globalStyles.spacing.dialogInsideMargin As the marginTop of title and marginBottom of buttons on messageBox.js had been set to 0.5em, I removed and added them to padding of flyoutDialog. The vaule was calculated this way: calc(10px + 0.5rem) = 18px. Also I applied it to the elements inside messageBox.js - Aligned the buttons to the right (same as messageBox.js) - Introduced siteInfo__wrapperLarge As the buttons on mixed content info dialog are so huge that sometimes they are wrapped, epecially on foreign language like Japanese. This is a temporary workaround to avoid it. - Moved 'denyRunInsecureContent' button to the right to improve UX - Updated automated test code Auditors: Test Plan: 1. Open https://apple.com 2. Click the lock icon on the URL bar 3. Make sure the title and description are aligned 4. Make sure the button is aligned to the right 5. Open http://apple.com 6. Click the unlock icon on the URL bar 7. Make sure the title and description are aligned 8. Open https://mixed-script.badssl.com 9. Click the lock icon 10. Make sure the buttons are aligned to the right and they are not wrapped 11. Click "Load Unsafe Script" 12. Click the unlock icon on the URL bar 13. Click "Stop Loading Unsafe Script" 14. Visit http://jsbin.com/fiyojusahu/edit?html,output 15. Make sure the elements are aligned well 16. Visit http://jsbin.com/sadunogefu/edit?html,output 17. Make sure the switch next to "Prevent this page from creating additional dialogs" is aligned with the body text
This was referenced Apr 9, 2017
This was referenced Apr 13, 2017
This was referenced Apr 21, 2017
alexwykoff
changed the title
luixxiul
changed the title
luixxiul
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
#7985 (comment)
Describe the issue you encountered: Refactor siteInfo.js with Aphrodite
Steps to reproduce:
Actual result:
Expected result:
Other screenshots are available on #7985 (comment)
Extra QA steps:
1.
2.
3.
Any related issues:
The text was updated successfully, but these errors were encountered: