Badge count animation between lion head and password manager needs to synchronize

[srirambv]

Test plan:

#9014 (comment)

---

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Badge count animation between lion head and password manager needs to synchronize

• Platform (Win7, 8, 10? macOS? Linux distro?):
  All

• Brave Version (revision SHA):
  Brave 0.14.2
  rev 61ae1a7

• Steps to reproduce:

  1. Enable LastPass with a stored credentials
  2. Visit the site for which the credentials is saved
  3. Hover over the next tab, LastPass badge is hidden, lion head badge still retained
  4. Switch back to the tab for which LastPass badge count is still not shown but lion head badge shows the badge
  5. Switch to the new tab, LastPass badge is still shown, lion head badge is hidden

• Actual result:
  Badge count animation between lion head and password manager needs to synchronize

• Expected result:
  Badge count should be shown properly on tabs

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  N/A

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  

• Any related issues:

[cezaraugusto]

@srirambv could you describe more fully what's the expected result here?

[cezaraugusto]

we could have an animation to smooth transitions but not sure if that's what you mean

[srirambv]

@cezaraugusto Yes there is no smooth transition in the counts. The badge count on lion head appears first and then for LastPass. Also when tab switches Lastpass retains badge and Lion head doesn't retain. On hover LastPass badge is lost but Lion head retians the badge

[cezaraugusto]

after a while animating badges I started to like them as-is if a subtle transition is included:

cc @srirambv @bradleyrichter what do you both think?

[luixxiul]

CC @bradleyrichter for design review

[srirambv]

Fade in effect on LastPass is a little slower compared to Honey. But much better than the initial transition 👍