Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Avoid having undefined props on tab audio indicator #8270

Closed
cezaraugusto opened this issue Apr 13, 2017 · 1 comment
Closed

Avoid having undefined props on tab audio indicator #8270

cezaraugusto opened this issue Apr 13, 2017 · 1 comment

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Apr 13, 2017

Test plan:

  • Indicator for audio must show if there's audio/video playing
  • Mute indicator must show show if there's audio/video playing
  • They should remain persistent while audio/video is playing

Some props on audio indicator (AudioTabIcon component) are undefined at some points possibly leading to unexpected behavior when the tab is idle (see #8249).

  • We should coerce all truthy/falsy values to boolean;
  • Since spec for tabs are now well defined, we should add a new breakpoint value for icon to be visible (it currently shows only when no breakpoint matches).
@bsclifton
Copy link
Member

Fixed with #8273

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.