Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tabs No Longer Show Full-Color Emoji #8414

Closed
jonathansampson opened this issue Apr 20, 2017 · 8 comments · Fixed by #10691
Closed

Tabs No Longer Show Full-Color Emoji #8414

jonathansampson opened this issue Apr 20, 2017 · 8 comments · Fixed by #10691
Assignees
@jonathansampson @cezaraugusto
Labels
bug design A design change, especially one which needs input from the design team. feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Apr 20, 2017 •
edited by luixxiul
Loading

Test plan

#10691 (comment)

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Tabs used to show full-color emoji; now they are rendered as solid shapes. It is reported that Brave used to render these as full-color in recent history (a month or so ago).

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10

  • Brave Version (revision SHA):
    632a9bc

  • Steps to reproduce:

    1. Navigate to https://codepen.io/thebabydino/pen/Wxpzdy
    2. Check tab contents for full-color emoji

  • Actual result:
    Solid circles are rendered

  • Expected result:
    Full-color emoji are rendered

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Screenshot if needed:

image
@jonathansampson jonathansampson added bug design A design change, especially one which needs input from the design team. feature/tabsbar labels Apr 20, 2017
@jonathansampson jonathansampson added this to the 0.15.1 milestone Apr 20, 2017
@jonathansampson
Copy link
Collaborator Author

@cezaraugusto Might we have lost support when we refactored the tab UI at the all-hands?

@cndouglas
Copy link

That explains the white blobs I've been seeing in 0.14.1!

@cezaraugusto
Copy link
Contributor

yep, that's related to gradient opacity for tab titles introduced there.

Color is set to transparent to make use of background-clip and bg gradient. A good alternative would be moving that gradient somewhere else or just add another layer for that.

@jonathansampson
Copy link
Collaborator Author

@cezaraugusto Awesome. I'm happy to take this and work on a PR if you like.

@cezaraugusto
Copy link
Contributor

🎉 awesome, thanks!

@jonathansampson jonathansampson self-assigned this Apr 21, 2017
@bbondy bbondy removed this from the 0.15.2 milestone May 2, 2017
@bsclifton bsclifton mentioned this issue Jul 12, 2017
Closed
@cezaraugusto cezaraugusto self-assigned this Aug 22, 2017
@cezaraugusto cezaraugusto added this to the 0.20.x (Developer Channel) milestone Aug 22, 2017
cezaraugusto added a commit that referenced this issue Aug 28, 2017
@cezaraugusto
improve performance for tabs, include intersectionObserver
efeb942 
fix #10611
fix #10582
fix #10544
fix #10509
fix #10123
fix #9998
fix #9398
fix #8414
fix #7925
fix #7730
fix #7301
fix #6957
@cezaraugusto cezaraugusto mentioned this issue Aug 28, 2017
Merged
cezaraugusto added a commit that referenced this issue Aug 29, 2017
@cezaraugusto
improve performance for tabs, include intersectionObserver
7660913 
fix #10611
fix #10582
fix #10544
fix #10509
fix #10123
fix #9998
fix #9398
fix #8414
fix #7925
fix #7730
fix #7301
fix #6957
@ghost ghost added the sprint/1 label Sep 13, 2017
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
add gradient layer to mimic current title gradient
019522e 
- text w/ gradient can be buggy. Let's do it with a layer
Auditors: @luixxiul
fix #8414
fix #9398
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
add gradient layer to mimic current title gradient
86d57fc 
- text w/ gradient can be buggy. Let's do it with a layer
Auditors: @luixxiul
fix #8414
fix #9398
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
add gradient layer to mimic current title gradient
a1f1821 
- text w/ gradient can be buggy. Let's do it with a layer
Auditors: @luixxiul
fix #8414
fix #9398
@luixxiul
Copy link
Contributor

does this issue cover the issue on https://spoofed-favicon.badssl.com/ or do we track that on another issue?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Sep 15, 2017
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
add gradient layer to mimic current title gradient
f4780d3 
- text w/ gradient can be buggy. Let's do it with a layer
Auditors: @luixxiul
fix #8414
fix #9398
@cezaraugusto
Copy link
Contributor

@luixxiul I think that's a different one.

@jonathansampson
Copy link
Collaborator Author

@luixxiul Is there an issue for that? Curious what @diracdeltas thinks about sites showing a lock as their favicon.

cezaraugusto added a commit that referenced this issue Sep 19, 2017
@cezaraugusto
add gradient layer to mimic current title gradient
a25ca8f 
- text w/ gradient can be buggy. Let's do it with a layer
Auditors: @luixxiul
fix #8414
fix #9398
cezaraugusto added a commit that referenced this issue Sep 21, 2017
@cezaraugusto
add gradient layer to mimic current title gradient
80af744 
- text w/ gradient can be buggy. Let's do it with a layer
Auditors: @luixxiul
fix #8414
fix #9398
@luixxiul luixxiul added QA/test-plan-specified release-notes/include and removed needs-info Another team member needs information from the PR/issue opener. release/not-blocking labels Sep 21, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@cezaraugusto @syuan100
add gradient layer to mimic current title gradient
b25c3eb 
- text w/ gradient can be buggy. Let's do it with a layer
Auditors: @luixxiul
fix brave#8414
fix brave#9398
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonathansampson jonathansampson

@cezaraugusto cezaraugusto

Labels
bug design A design change, especially one which needs input from the design team. feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

improve tabs performance and UI with this one simple trick brave/browser-laptop
7 participants
@jonathansampson @bbondy @luixxiul @cezaraugusto @srirambv @cndouglas @LaurenWags