Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Avoid circular dependency in reducers with appState #8428

Closed
bsclifton opened this issue Apr 21, 2017 · 0 comments
Closed

Avoid circular dependency in reducers with appState #8428

bsclifton opened this issue Apr 21, 2017 · 0 comments

Comments

@bsclifton
Copy link
Member

Discovered while testing 0.15.0 (on dev-channel) after bc6fda7 was pulled in

error seen is:

> [email protected] start /Users/clifton/Documents/browser-laptop
> node ./tools/start.js --user-data-dir=brave-development --enable-logging --v=0 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck

Crash reporting enabled
2017-04-21 15:15:39.187 Brave Helper[23589:933658] Couldn't set selectedTextBackgroundColor from default ()
An uncaught exception occurred in the main process Uncaught Exception:
TypeError: AppStore.getState is not a function
    at EventEmitter.ipcMain.on (/Users/clifton/Documents/browser-laptop/app/browser/reducers/passwordManagerReducer.js:104:32)
    at emitThree (events.js:116:13)
    at EventEmitter.emit (events.js:194:7)
    at WebContents.<anonymous> (/Users/clifton/Documents/browser-laptop/node_modules/electron-prebuilt/dist/Brave.app/Contents/Resources/electron.asar/browser/api/web-contents.js:182:13)
    at emitTwo (events.js:106:13)
    at WebContents.emit (events.js:191:7)
@bsclifton bsclifton added this to the 0.15.1 milestone Apr 21, 2017
@bbondy bbondy modified the milestones: 0.15.3, 0.15.2 May 2, 2017
@alexwykoff alexwykoff removed this from the 0.16.100 milestone May 23, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@NejcZdovc NejcZdovc removed their assignment Jan 12, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants