Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Hiding menu shows empty white space #8839

Closed
sorin-davidoi opened this issue May 11, 2017 · 8 comments
Closed

Hiding menu shows empty white space #8839

sorin-davidoi opened this issue May 11, 2017 · 8 comments
Assignees
@bsclifton
Labels
bug feature/navbar OS/unix-like/linux QA/checked QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@sorin-davidoi
Copy link

sorin-davidoi commented May 11, 2017 •
edited by bsclifton
Loading

Test plan

  1. Launch Brave on Linux (under Gnome)
  2. Press ALT to toggle the menu
  3. the menu should show and hide, leaving no white space behind

Original issue description

  • Did you search for similar issues before submitting this one?

Yes

  • Describe the issue you encountered:

Hiding the menu by pressing the alt key shows an empty space instead of hiding it.

  • Platform (Win7, 8, 10? macOS? Linux distro?):

ArchLinux

  • Brave Version (revision SHA):

0.15.301 (4e86cab)

  • Steps to reproduce:

    1. Press Alt to hide the menu bar

  • Actual result:

The menu bar is hidden, but an empty white container is shown instead.

  • Expected result:

The menu bar is hidden, saving vertical space.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

Yes.

  • Is this an issue in the currently released version?

Yes.

  • Can this issue be consistently reproduced?

Yes.

  • Screenshot if needed:
    brave-menu-hide
@luixxiul
Copy link
Contributor

I remember I noticed that kind of white space on Debian.

@sorin-davidoi
Copy link
Author

I think it was introduced with 0.15.3 (did not noticed it with 0.15.2).

@admshao
Copy link

admshao commented May 12, 2017

I have the same problem on Archlinux, 0.15.2 was fine

@bsclifton
Copy link
Member

I think this problem is related to the changes I recently made in Muon with brave/muon@5012b72

Linux has an open issue (captured in #5086) which I believe is the root cause for this

@bsclifton bsclifton added this to the 0.15.400 milestone May 12, 2017
@bsclifton bsclifton self-assigned this May 12, 2017
@sorin-davidoi
Copy link
Author

Also noticed that the menu / white container does not disappear when a video is full-screen.

@admshao
Copy link

admshao commented May 13, 2017

It does appear for me while in Video fullscreen.
GNOME Shell 3.24.2 / XServer 1.19.3

@bsclifton bsclifton modified the milestones: 0.15.300, 0.15.400 May 16, 2017
@bsclifton
Copy link
Member

Looking into this now...

bsclifton added a commit to brave/muon that referenced this issue May 17, 2017
@bsclifton
Menu is now properly hidden when toggled (only used in Brave for Linux).
4b04c7b 
Initial PR was done with #191 but I missed electron/electron@dcf6c52

Fixes brave/browser-laptop#8839

Auditors: @bbondy, @bridiver
@bsclifton bsclifton mentioned this issue May 17, 2017
Merged
@bsclifton
Copy link
Member

Found the root cause and fixed 😄

@alexwykoff alexwykoff mentioned this issue May 23, 2017
Closed
21 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug feature/navbar OS/unix-like/linux QA/checked QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
6 participants
@alexwykoff @sorin-davidoi @luixxiul @bsclifton @admshao @srirambv