Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Title is not updated when using navigation buttons #8908

Closed
NejcZdovc opened this issue May 17, 2017 · 3 comments
Closed

Title is not updated when using navigation buttons #8908

NejcZdovc opened this issue May 17, 2017 · 3 comments

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented May 17, 2017

Test plan

#8992 (comment)


  • Did you search for similar issues before submitting this one?
    yes
  • Describe the issue you encountered:
    Title is not updated when using navigation buttons
  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS
  • Brave Version (revision SHA):
    8bb62f7
  • Steps to reproduce:
    1. go to site clifton.io
    2. create a history
    3. click on back/forward buttons

18

  • Actual result:
    sometimes tab title is not display (location is shown)
  • Expected result:
    title should be displayed
  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes
  • Is this an issue in the currently released version?
    no
  • Can this issue be consistently reproduced?
    not all the time but with few clicks you can see a problem
@bsclifton
Copy link
Member

Closing as a dupe of #7765. If I'm wrong about this (ex: title does not update on mouse over) please reopen. Thanks 😄

@bsclifton bsclifton removed this from the 0.15.300 milestone May 19, 2017
@bsclifton bsclifton added the duplicate Issue has already been reported label May 19, 2017
@NejcZdovc NejcZdovc removed the duplicate Issue has already been reported label May 20, 2017
@NejcZdovc
Copy link
Contributor Author

This is not a dupe, because as you can see in a gif if you hover over it nothing changes. I debug it a little bit and title is not set in our state (in #7765 everything is set ok, just DOM is not displayed correctly). So this regressed somewhere (race condition or something is not updating) when we were refactoring tabs. I think that this needs to be fixed in 0.15.30x, because this is something that is not happening in 0.15.2 and it's really bad.

@NejcZdovc NejcZdovc reopened this May 20, 2017
@NejcZdovc NejcZdovc added this to the 0.15.300 milestone May 20, 2017
@bsclifton
Copy link
Member

This is what causes the title to change:
https://github.com/brave/browser-laptop/blob/master/app/renderer/components/main/main.js#L323

Looking at the code here, it looks like this was a known issue and a hacky work-around was put in place:
https://github.com/brave/browser-laptop/blob/master/app/renderer/components/frame/frame.js#L654

cc: @NejcZdovc @bridiver

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 21, 2017
Resolves brave#8908

Auditors: @bsclifton @bridiver

Test Plan:
- go to site clifton.io
- create a history
- click on back/forward buttons
- check that title is always correct
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 22, 2017
Resolves brave#8908

Auditors: @bsclifton @bridiver

Test Plan:
- go to site clifton.io
- create a history
- click on back/forward buttons
- check that title is always correct
NejcZdovc added a commit that referenced this issue May 22, 2017
bsclifton pushed a commit that referenced this issue May 22, 2017
Resolves #8908

Auditors: @bsclifton @bridiver

Test Plan:
- go to site clifton.io
- create a history
- click on back/forward buttons
- check that title is always correct
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.