This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix various sorting problems with url suggestions #8994
Assignees
Milestone
Comments
bbondy
added a commit
that referenced
this issue
May 22, 2017
Fix #8994 Auditors: @bsclifton - Handle bookmarks that appear twice in folders with different counts. - Handle comparing items with no counts. - Handle comparing items with no lastAccessedTime - Handle sorting 2 sites when one is a substring of the other, match the shorter one first. - Fixed an issue with Immutable data sometimes being used in the sorting functions, and adds an assert to make sure it's correctly used. - Support `javascript:` bookmarklets - Avoid re-sorting suggestions that are generated - Adds lots of tests
21 tasks
bbondy
added a commit
that referenced
this issue
May 25, 2017
Fix #8994 Historically there was some code that set 0 to null since we used to use 1 based ordinals instead of 0 based indexes, and it causes a bug where the first item can't be selected.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
shorter one first.
sorting functions, and adds an assert to make sure it's correctly
used.
javascript:bookmarkletsThe text was updated successfully, but these errors were encountered: