Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

window.prompt is not supported currently #94

Closed
bbondy opened this issue Dec 24, 2015 · 22 comments
Closed

window.prompt is not supported currently #94

bbondy opened this issue Dec 24, 2015 · 22 comments
Assignees
@bsclifton
Labels
bug crash parity Features which should be supported in Brave since they're supported in other major browsers. priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.23.x Release 5 ...

Comments

@bbondy
Copy link
Member

bbondy commented Dec 24, 2015 •
edited by bsclifton
Loading

Test plan

  1. Visit https://www.w3schools.com/js/tryit.asp?filename=tryjs_prompt
  2. Click the Try it button on the right hand side
  3. Confirm prompt is shown; text should be selected
  4. Type Brave and click OK
  5. Confirm Hello Brave! How are you today? is shown
  6. Repeat steps 2 - 5, except press enter to submit instead of clicking OK
  7. Click the Try it button on the right hand side
  8. Click Cancel button
  9. Confirm User cancelled the prompt. is shown
  10. Repeat steps 8 and 9 except press escape instead of clicking Cancel

Original issue description

We can patch here:
https://github.com/atom/electron/blob/c4931bb2d12f5905cdf434ed6ff1a755ccad053f/atom/renderer/lib/override.coffee#L92

window.prompt
@bridiver
Copy link
Collaborator

I think the work I'm doing in electron right now might help out with this

@diracdeltas
Copy link
Member

looks like prompt is still not supported?

This was referenced May 18, 2016
Closed
Closed
@luixxiul
Copy link
Contributor

luixxiul commented May 22, 2016 •
edited
Loading

So maybe is this the reason of #1723, #1311, #1859 and like that?

@luixxiul luixxiul mentioned this issue May 22, 2016
Closed
@luixxiul luixxiul mentioned this issue Jul 24, 2016
Closed
@CliqueBait CliqueBait mentioned this issue Aug 21, 2016
Closed
@bsclifton bsclifton added the parity Features which should be supported in Brave since they're supported in other major browsers. label Aug 22, 2016
@bsclifton
Copy link
Member

+1 from @CliqueBait via #3295

@jemspatel jemspatel mentioned this issue Sep 18, 2016
Closed
@luixxiul luixxiul added this to the 1.1.0 milestone Nov 10, 2016
@cndouglas cndouglas mentioned this issue Nov 16, 2016
Closed
@jonathansampson
Copy link
Collaborator

+1 from Twitter; a user who would like to use Brave internally, but cannot due to the lack of window.prompt: https://twitter.com/jamonholmgren/status/821964305964765184

@luixxiul luixxiul mentioned this issue Feb 5, 2017
Closed
@luixxiul luixxiul modified the milestones: 1.0.0, 1.1.0 Feb 5, 2017
@luixxiul luixxiul changed the title prompt is not supported currently window.prompt is not supported currently Feb 5, 2017
@bsclifton
Copy link
Member

@bridiver do you know if the underlying support is there for this? If so, I can knock this out pretty easily. It should help w/ out extension support

@marktani
Copy link

marktani commented Feb 7, 2017 •
edited
Loading

We are currently relying on window.prompt for our dashboard, so support for this would be highly appreciated! :)

@jonathansampson
Copy link
Collaborator

Just learned from a user today that WooCommerce (3+ million WordPress users) uses window.prompt.

@CliqueBait
Copy link

+1 from Community: https://community.brave.com/t/dialogue-alert-pop-up-preferences/1974

@jonathansampson
Copy link
Collaborator

Chromium to change behavior of dialogs: Chromium policy on JavaScript dialogs

@bsclifton bsclifton self-assigned this Apr 3, 2017
@bsclifton bsclifton modified the milestones: 0.14.3, 1.0.0 Apr 3, 2017
@alexwykoff alexwykoff modified the milestones: 1.2.0, 0.15.1 Apr 18, 2017
@jonasgeiler
Copy link

jonasgeiler commented May 17, 2017 •
edited
Loading

1+ need it for my WebApp....
(#push)

@bsclifton bsclifton modified the milestones: Backlog (Prioritized), 0.23.x (Nightly Channel) Feb 7, 2018
@bsclifton
Copy link
Member

Tentatively assigning to 0.23.x since this does cause a crash

@bsclifton bsclifton added the crash label Feb 7, 2018
@bsclifton bsclifton modified the milestones: 0.23.x (Nightly Channel), 0.24.x, Completed work, Backlog (Prioritized) Feb 26, 2018
@srirambv
Copy link
Collaborator

+3 from https://community.brave.com/t/brave-crashes-upon-javascript-popup-in-google-tasks/15138/6

@bsclifton can this be moved up to 0.24.x?

AlexRobinson- added a commit to AlexRobinson-/browser-laptop that referenced this issue Mar 22, 2018
@AlexRobinson-
Add feature window.prompt
ef1cb6c 
This sa first pass at implementing the JavaScript function window.prompt.

closes brave#94
@AlexRobinson- AlexRobinson- mentioned this issue Mar 23, 2018
Merged
10 tasks
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), 0.24.x (Nightly Channel) Mar 30, 2018
bsclifton pushed a commit to AlexRobinson-/browser-laptop that referenced this issue May 2, 2018
@AlexRobinson- @bsclifton
Add feature window.prompt
1a91cc6 
This is a first pass at implementing the JavaScript function window.prompt.

closes brave#94

- Add translations for message box 'ok' and 'cancel'
- Introduce PromptTextbox and use it in messageBox for window.prompt
@shortstuffsushi
Copy link

🎉 Thanks guys. Now if I want to super lazily implement user input, I don't have to do any extra work.

@LaurenWags
Copy link
Member

+1 from community: https://community.brave.com/t/javascript-prompt-not-prompting/11315

@eljuno eljuno mentioned this issue Jul 9, 2018
Closed
This was referenced Aug 14, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Aug 14, 2018 •
edited by srirambv
Loading

Verified with macOS 10.12.6 using

  • 0.23.80 53a429f
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

Verified on Ubuntu 18 x64 using

  • 0.23.80 53a429f
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

@kjozwiak kjozwiak mentioned this issue Aug 28, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug crash parity Features which should be supported in Brave since they're supported in other major browsers. priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.23.x Release 5 (Release Channel)
Development

No branches or pull requests