Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"History" disappeared from menu #9471

Closed
eljuno opened this issue Jun 14, 2017 · 3 comments · Fixed by #9477
Closed

"History" disappeared from menu #9471

eljuno opened this issue Jun 14, 2017 · 3 comments · Fixed by #9477
Assignees
@ayumi
Labels
bug feature/history OS/Windows QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.17.13 (Release ...

Comments

@eljuno
Copy link
Contributor

eljuno commented Jun 14, 2017 •
edited by bsclifton
Loading

Test plan

See #9477

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes. But maybe I missed the existing issue.

  • Describe the issue you encountered:
    History not shown in menu. Can not click on it.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Win 8.1

  • Brave Version (revision SHA):
    0.17.1 (6482f15)

  • Steps to reproduce:

    1. Show menu by click Alt on keyboard.
    2. Noticed that History is not there.

  • Actual result:
    There's no History. Only empty space.

  • Expected result:
    History and its sub-menu is shown.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?
    Yes.

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    brave-history-menu-missing

  • Any related issues:
@bsclifton
Copy link
Member

bsclifton commented Jun 14, 2017 •
edited
Loading

cc: @ayumi

Could this be related to #9191?

@ayumi
Copy link
Contributor

ayumi commented Jun 14, 2017

@eljuno thanks for finding this! I've repro'd on Windows 10, Brave 0.17.2 839e68b
STR:

  • Fresh Brave; activate system app menu with Alt; looks normal
  • Open webpage in new tab
  • Close the tab
  • Alt; system app app menu is missing History

@bsclifton likely related to #9191. I developed on MacOS and the windows code path is slightly different.

ayumi added a commit that referenced this issue Jun 14, 2017
@ayumi
Fix History recently closed items for Windows
e6588ed 
Fix #9471

Test Plan:

0. Be on Windows
1. Open the History menu and note Recently closed is not there.
2. Go to https://archive.org
3. Open a new tab and go to https://wikipedia.org
4. Close the tab
5. Examine the menu History > Recently closed; it should have Wikipedia
6. Close the archive.org tab
7. Examine the Recently closed menu; it should have the Internet archive
8. Use the menu item "Reopen last closed tab" or use the shortcut
9. Examine the Recently closed menu; it should be hidden now.
@ayumi ayumi mentioned this issue Jun 14, 2017
Merged
8 tasks
@bsclifton bsclifton added this to the 0.17.x (Beta Channel) milestone Jun 15, 2017
@darkdh darkdh mentioned this issue Jun 15, 2017
Closed
@luixxiul luixxiul added the bug label Jun 15, 2017
@bsclifton
Copy link
Member

Marking as release-notes/exclude since this was introduced (and then fixed) in the same release 😄

This was referenced Jun 19, 2017
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jun 23, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ayumi ayumi

Labels
bug feature/history OS/Windows QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fix system menu History :: Recently closed items for Windows brave/browser-laptop
6 participants
@ayumi @alexwykoff @luixxiul @bsclifton @srirambv @eljuno