Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Sort top sites more deterministically #9541

Closed
jonathansampson opened this issue Jun 18, 2017 · 3 comments
Closed

Sort top sites more deterministically #9541

jonathansampson opened this issue Jun 18, 2017 · 3 comments

Comments

@jonathansampson
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Auto-suggestions cycle through every google domain imaginable.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Desktop

  • Brave Version (revision SHA):
    c5968c5

  • Steps to reproduce:

    1. Slowly type "google.com" into the address bar
  • Actual result:
    Note that the active suggestion cycles through numerous variants of this domain.

  • Expected result:
    I should only be suggested the variant of google that matches my language/region.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    N/A

  • Can this issue be consistently reproduced?
    Yes

  • Screenshot if needed:

this-google-that-google

  • Any related issues:
@luixxiul luixxiul added the bug label Jun 18, 2017
@bsclifton bsclifton added this to the 0.17.x (Beta Channel) milestone Jun 18, 2017
@bsclifton
Copy link
Member

Marked with needs-triage and assigned to 0.17.x for now. Will review with others on Tuesday to determine priority

@bbondy bbondy changed the title Brave Recommends All of the Googles! Sort top sites more deterministically Jun 19, 2017
bbondy added a commit that referenced this issue Jun 19, 2017
@alexwykoff alexwykoff mentioned this issue Jun 19, 2017
10 tasks
@srirambv
Copy link
Collaborator

srirambv commented Jun 21, 2017

@jonathansampson Is this expected?
image
image

Expected result:
I should only be suggested the variant of google that matches my language/region.

I have the region set as Ireland and language as EN-US but I see Google suggestion for India and Germany along with US when I type in google.c and I see suggestions for India and UK along with US when I just type goog

@bsclifton
Copy link
Member

@srirambv the top sites are just Alexa top sites; no criteria (such as location) is removing entries, so they will show all entries

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.