Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

urlbar icon disappears when video starts playing #9652

Closed
diracdeltas opened this issue Jun 21, 2017 · 0 comments
Closed

urlbar icon disappears when video starts playing #9652

diracdeltas opened this issue Jun 21, 2017 · 0 comments
Assignees
@diracdeltas
Labels
feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include security
Milestone
0.18.x Release

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jun 21, 2017 •
edited by luixxiul
Loading

Test plan

#9727 (comment)

confirmed on master and in 0.16.9 on osx

  1. go to https://video.foxbusiness.com/v/5068842750001/?#sp=show-clips
  2. 'allow ads' so that the video will play
  3. notice that the URL bar icon disappears when the video starts
@diracdeltas diracdeltas added this to the 0.18.x (Developer Channel) milestone Jun 21, 2017
diracdeltas added a commit that referenced this issue Jun 27, 2017
@diracdeltas
Send isSecure false instead of null when an insecure site has passive…
3935f58 
… mixed content

Fix #9652

If a site is already insecure and receives passive mixed content, the security state should remain insecure instead of changing to unknown.

Test Plan:
1. go to https://video.foxbusiness.com/v/5068842750001/?#sp=show-clips
2. click 'allow ads' so that the video will play
3. the URL bar icon should not disappear when the video starts
@diracdeltas diracdeltas mentioned this issue Jun 27, 2017
Merged
8 tasks
This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include security
Projects
None yet
Milestone
0.18.x Release
Development

No branches or pull requests
4 participants
@diracdeltas @luixxiul @srirambv @LaurenWags