Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Only primitives in TabPage #9793

Closed
NejcZdovc opened this issue Jun 30, 2017 · 1 comment · Fixed by #9794
Closed

Only primitives in TabPage #9793

NejcZdovc opened this issue Jun 30, 2017 · 1 comment · Fixed by #9794
Assignees
@NejcZdovc
Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 30, 2017 •
edited by luixxiul
Loading

Test plan

#9794 (comment)

Describe the issue you encountered:
Remove tabPageFrames from mergeProps.
@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 30, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 30, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 30, 2017
@NejcZdovc
Removes non-primitive types from TabPage
7e14c30 
Resolves brave#9793

Auditors: @bsclifton @bridiver

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jun 30, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 4, 2017
@NejcZdovc
Removes non-primitive types from TabPage
ce69e5f 
Resolves brave#9793

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 4, 2017
@NejcZdovc
Removes non-primitive types from TabPage
28baeee 
Resolves brave#9793

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 5, 2017
@NejcZdovc
Removes non-primitive types from TabPage
a117b9f 
Resolves brave#9793

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 5, 2017
@NejcZdovc
Merge pull request #9794 from NejcZdovc/refactor/#9793-tabpage
ee7e6da 
Removes non-primitive types from TabPage
NejcZdovc added a commit that referenced this issue Jul 5, 2017
@NejcZdovc
Removes non-primitive types from TabPage
e782ec6 
Resolves #9793

Auditors: @bsclifton @bridiver

Test Plan:
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 20, 2017
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

Closing tab page causes #11028 but works fine on Windows

This was referenced Sep 21, 2017
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

Successfully merging a pull request may close this issue.

Removes non-primitive types from TabPage NejcZdovc/browser-laptop
4 participants
@luixxiul @NejcZdovc @srirambv @LaurenWags