This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
Add support for dynamic breakpoint for tabs #10134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10134 +/- ##
=======================================
Coverage 54.33% 54.33%
=======================================
Files 245 245
Lines 21156 21156
Branches 3260 3260
=======================================
Hits 11495 11495
Misses 9661 9661
|
the milestone was moved to the latest one to test the change well. |
luixxiul
reviewed
Aug 14, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test plan works.
bsclifton
approved these changes
Aug 15, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested (before and after change)- works great 😄 👍
bsclifton
added
QA/test-plan-specified
release-notes/include
misc/button
misc/favicon
and removed
PR/needs-QA-attention ☕
labels
Aug 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Please see #9779 for integrated manual test plan;
Reviewer Checklist:
Tests