Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

replace node classList with dataset #10445

Merged
merged 2 commits into from
Aug 17, 2017
Merged

replace node classList with dataset #10445

merged 2 commits into from
Aug 17, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Aug 11, 2017

fix #10443
unblocks #10234

  1. have enough bookmarks to show the overflow indicator
  2. click the overflow, should open
  3. open a bookmark pull down with children
  4. you should be able to click the second level child
  5. second level child should be nested visually with its parent

@cezaraugusto cezaraugusto added this to the 0.21.x (Nightly Channel) milestone Aug 11, 2017
@cezaraugusto cezaraugusto self-assigned this Aug 11, 2017
@codecov-io
Copy link

codecov-io commented Aug 11, 2017

Codecov Report

Merging #10445 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10445      +/-   ##
==========================================
- Coverage   53.81%   53.81%   -0.01%     
==========================================
  Files         238      238              
  Lines       21054    21053       -1     
  Branches     3258     3258              
==========================================
- Hits        11330    11329       -1     
  Misses       9724     9724
Flag Coverage Δ
#unittest 53.81% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
app/renderer/components/common/browserButton.js 69.04% <ø> (-0.72%) ⬇️

Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test plan works, thanks.

@cezaraugusto cezaraugusto merged commit ae5b24c into master Aug 17, 2017
@cezaraugusto cezaraugusto deleted the 10443 branch August 17, 2017 02:46
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
@srirambv
Copy link
Collaborator

Not seeing any second level child due to #12052

@srirambv
Copy link
Collaborator

@cezaraugusto Is this expected?
10445

@cezaraugusto
Copy link
Contributor Author

can't see a bug in the screenshot what's missing?

@srirambv
Copy link
Collaborator

The nested items open on to the left used to be right

@cezaraugusto
Copy link
Contributor Author

ya it's expected because the parent menu is on the right. Chrome does the same

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace node classList instances with dataset
5 participants