This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
apply brave UA whitelist to first-party subresources #10904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #10800 Test Plan: load adobe.com within Brave open the developer tools via "option + command + I" select the "Network" tab and reload adobe.com via "command + r" select on the first resource and you'll notice the correct Brave Chrome/60.0.3112.101 UA select another resource that's underneath the first one and is from Host:www.adobe.com the Brave UA should be there
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## master #10904 +/- ##
==========================================
+ Coverage 54.14% 54.18% +0.04%
==========================================
Files 248 249 +1
Lines 21751 21798 +47
Branches 3383 3392 +9
==========================================
+ Hits 11777 11812 +35
- Misses 9974 9986 +12
|
- filtering.getMainFrameUrl is called (which also queries webcontents; no test for that yet) - hack considers subdomain Auditors: @diracdeltas . Auditors: Test Plan:
bsclifton
force-pushed
the
fix/10800
branch
from
4b35f3d
to
25c9492
Compare
bsclifton
reviewed
Sep 14, 2017
|
@bsclifton IIUC provisional headers are shown before the filtering is applied, so that seems fine |
bsclifton
added a commit
that referenced
this pull request
Sep 15, 2017
apply brave UA whitelist to first-party subresources
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10800
Test Plan:
load adobe.com within Brave
open the developer tools via "option + command + I"
select the "Network" tab and reload adobe.com via "command + r"
select on the first resource and you'll notice the correct Brave Chrome/60.0.3112.101 UA
select another resource that's underneath the first one and is from Host:www.adobe.com
the Brave UA should be there
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests