Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Followup #10605: Fixes window isFocused function that was not updated #10991

Merged
merged 1 commit into from
Sep 18, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 17, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

This happened because #10458 was stale for long then #10605 was stale again and not rebase to the latest master before merging.

Auditors: @bbondy

Test Plan:

  • try to run brave
  • brave should start normally

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Sep 17, 2017
@NejcZdovc NejcZdovc self-assigned this Sep 17, 2017
Auditors: @bbondy

Test Plan:
- try to run brave
- brave should start normally
@codecov-io
Copy link

codecov-io commented Sep 17, 2017

Codecov Report

Merging #10991 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master   #10991   +/-   ##
=======================================
  Coverage   54.21%   54.21%           
=======================================
  Files         249      249           
  Lines       21816    21816           
  Branches     3395     3395           
=======================================
  Hits        11827    11827           
  Misses       9989     9989
Flag Coverage Δ
#unittest 54.21% <0%> (ø) ⬆️
Impacted Files Coverage Δ
app/renderer/components/navigation/navigator.js 75.18% <0%> (ø) ⬆️

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging now as mentioned PR made master unusable ++

@cezaraugusto cezaraugusto merged commit be6e05e into brave:master Sep 18, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants