Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix table multi-select after sort #11056

Merged
merged 1 commit into from
Sep 21, 2017
Merged

fix table multi-select after sort #11056

merged 1 commit into from
Sep 21, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Sep 20, 2017

fix #10971

test plan:

  1. browse some sites, then go to about:history
  2. click on any of the columns to sort the table
  3. shift+click to select multiple entries
  4. contiguous table entries should be selected, not random entries

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

fix #10971

test plan:
1. browse some sites, then go to about:history
2. click on any of the columns to sort the table
3. shift+click to select multiple entries
4. contiguous table entries should be selected, not random entries
@diracdeltas diracdeltas added this to the 0.20.x (Developer Channel) milestone Sep 20, 2017
@diracdeltas diracdeltas self-assigned this Sep 20, 2017
@codecov-io
Copy link

codecov-io commented Sep 21, 2017

Codecov Report

Merging #11056 into master will increase coverage by 0.01%.
The diff coverage is 23.52%.

@@            Coverage Diff             @@
##           master   #11056      +/-   ##
==========================================
+ Coverage   54.61%   54.63%   +0.01%     
==========================================
  Files         249      249              
  Lines       21951    21949       -2     
  Branches     3435     3436       +1     
==========================================
+ Hits        11989    11992       +3     
+ Misses       9962     9957       -5
Flag Coverage Δ
#unittest 54.63% <23.52%> (+0.01%) ⬆️
Impacted Files Coverage Δ
app/renderer/components/common/sortableTable.js 61.75% <23.52%> (+1.31%) ⬆️

Copy link
Contributor

@ayumi ayumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻

@diracdeltas diracdeltas merged commit 954f0ab into master Sep 21, 2017
@diracdeltas diracdeltas deleted the fix/10971 branch September 21, 2017 21:09
diracdeltas added a commit that referenced this pull request Sep 21, 2017
fix table multi-select after sort
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shift+click in a sortable table is broken after sorting it
3 participants