Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add volatility text to BAT screen #11342

Merged
merged 1 commit into from
Oct 9, 2017
Merged

Add volatility text to BAT screen #11342

merged 1 commit into from
Oct 9, 2017

Conversation

srirambv
Copy link
Collaborator

@srirambv srirambv commented Oct 7, 2017

Submitter Checklist:
Fixes:#11332

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:
Ensure wizard shows volatility text when add funds is clicked
image

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@codecov-io
Copy link

codecov-io commented Oct 7, 2017

Codecov Report

Merging #11342 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11342      +/-   ##
==========================================
- Coverage   52.51%   52.48%   -0.04%     
==========================================
  Files         267      267              
  Lines       24982    24982              
  Branches     3997     3997              
==========================================
- Hits        13120    13111       -9     
- Misses      11862    11871       +9
Flag Coverage Δ
#unittest 52.48% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
.../payment/addFundsDialog/steps/addFundsBatScreen.js 68.75% <ø> (ø) ⬆️
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.37% <0%> (-6.25%) ⬇️
js/stores/windowStore.js 27.27% <0%> (-0.31%) ⬇️

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one sir, thanks

@cezaraugusto cezaraugusto merged commit 13f44e8 into brave:master Oct 9, 2017
@cezaraugusto cezaraugusto mentioned this pull request Oct 9, 2017
8 tasks
cezaraugusto added a commit that referenced this pull request Oct 9, 2017
Add volatility text to BAT screen
@cezaraugusto
Copy link
Contributor

cezaraugusto commented Oct 9, 2017

master 13f44e8
0.20.x da15434
0.19.x 7f6f83a

cezaraugusto added a commit that referenced this pull request Oct 9, 2017
Add volatility text to BAT screen
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants