Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Unskip 'bitwarden installs when enabled' automated test #11358

Merged
merged 1 commit into from
Oct 9, 2017
Merged

Unskip 'bitwarden installs when enabled' automated test #11358

merged 1 commit into from
Oct 9, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Oct 8, 2017

Closes #11357
Follow-up to #4776

It should not be skipped since 0.19 as the extension is re-enabled on that version.

Auditors: @bsclifton

Test Plan:

  1. Run npm run test -- --grep='bitwarden installs when enabled'

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Closes #11357
Follow-up to #4776

It should not be skipped since 0.19 as the extension is re-enabled on that version.

Auditors: @bsclifton

Test Plan:
1. Run `npm run test -- --grep='bitwarden installs when enabled'`
@codecov-io
Copy link

codecov-io commented Oct 8, 2017

Codecov Report

Merging #11358 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11358      +/-   ##
==========================================
- Coverage   52.51%   52.48%   -0.04%     
==========================================
  Files         267      267              
  Lines       24982    24982              
  Branches     3997     3997              
==========================================
- Hits        13120    13111       -9     
- Misses      11862    11871       +9
Flag Coverage Δ
#unittest 52.48% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.37% <0%> (-6.25%) ⬇️
js/stores/windowStore.js 27.27% <0%> (-0.31%) ⬇️

@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 8, 2017

https://travis-ci.org/brave/browser-laptop/jobs/284921496#L3362

    bitwarden installs when enabled
      ✓ installs (1594ms)

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit d39d84b into brave:master Oct 9, 2017
@cezaraugusto cezaraugusto deleted the unskip-bitwarden-installs-when-enabled branch October 9, 2017 14:33
cezaraugusto added a commit that referenced this pull request Oct 9, 2017
…n-enabled

Unskip 'bitwarden installs when enabled' automated test
cezaraugusto added a commit that referenced this pull request Oct 9, 2017
…n-enabled

Unskip 'bitwarden installs when enabled' automated test
@cezaraugusto
Copy link
Contributor

master d39d84b
0.20.x eb350b7
0.19.x 4233328

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants