This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
fix bad tab page preview for the first tab set #11407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
approved these changes
Oct 10, 2017
There was a problem hiding this comment.
Nice find 😄 Since this fix is required for bbde7ac#diff-f5a0b45b8323a469e78cf98fb0c49b8fR467 of #10691, which landed on 0.20.x, I agree this fix should be landed on 0.20.x as well 👍
|
The Travis result confirms it 💯 |
Codecov Report
@@ Coverage Diff @@
## master #11407 +/- ##
=======================================
Coverage 52.53% 52.53%
=======================================
Files 267 267
Lines 24978 24978
Branches 3996 3996
=======================================
Hits 13122 13122
Misses 11856 11856
|
|
@cezaraugusto would you please merge this to |
bsclifton
pushed a commit
that referenced
this pull request
Oct 10, 2017
fix bad tab page preview for the first tab set
|
@bsclifton thanks for doing that 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bad tab page preview for the first tab set
fix #11269
Auditors: @luixxiul
This is in fact a port from the working version of 0.19.x:
https://github.com/brave/browser-laptop/blob/0.19.x/app/common/state/tabContentState.js#L90
given this broke in 0.20.x I'm setting the same milestone.
Test Plan: