Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Disable spellcheck when language list is empty #11758

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Nov 2, 2017

fix #11739

Auditors: @bbondy, @bsclifton

Test Plan:
a. Covered by unittest
b. Manuall test:

  1. Make spellchecker lang lists empty
  2. Type some random word on about:styles
  3. There shouldn't be any red underline

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

fix #11739

Auditors: @bbondy, @bsclifton

Test Plan:
a. Covered by unittest
b. Manuall test:
1. Make spellchecker lang lists empty
2. Type some random word on about:styles
3. There shouldn't be any red underline
@darkdh darkdh self-assigned this Nov 2, 2017
@codecov-io
Copy link

Codecov Report

Merging #11758 into master will decrease coverage by 0.01%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master   #11758      +/-   ##
==========================================
- Coverage   52.75%   52.74%   -0.02%     
==========================================
  Files         269      269              
  Lines       25668    25670       +2     
  Branches     4097     4099       +2     
==========================================
- Hits        13542    13540       -2     
- Misses      12126    12130       +4
Flag Coverage Δ
#unittest 52.74% <42.85%> (-0.02%) ⬇️
Impacted Files Coverage Δ
js/about/preferences.js 46.21% <0%> (-0.37%) ⬇️
app/browser/reducers/spellCheckerReducer.js 78.46% <100%> (-0.65%) ⬇️

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested, works great 😄 Includes tests, test plan looks good. Nice fix! ❤️

@bsclifton bsclifton merged commit 4cd4d20 into master Nov 3, 2017
@bsclifton bsclifton deleted the issue-11739 branch November 3, 2017 05:03
bsclifton added a commit that referenced this pull request Nov 3, 2017
Disable spellcheck when language list is empty
bsclifton added a commit that referenced this pull request Nov 3, 2017
Disable spellcheck when language list is empty
bsclifton added a commit that referenced this pull request Nov 3, 2017
Disable spellcheck when language list is empty
@bsclifton
Copy link
Member

master 4cd4d20
0.21.x c96591a
0.20.x 13e6e16
0.19.x e3a3043

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spell check should be disabled if no language is set
5 participants