Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

use CHROME_USER_DATA_DIR to set/override the user data dir in tests #11775

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Nov 2, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:
messages about deleting directories should mostly go away in automated test runs
BRAVE_USER_DATA_DIR can be used to override the directory for tests

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bridiver bridiver self-assigned this Nov 2, 2017
Copy link
Contributor

@ayumi ayumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related muon PR: brave/muon#375

@bridiver
Copy link
Collaborator Author

bridiver commented Nov 2, 2017

muon PR is related, but not required. It's broken already and this doesn't make it any more broken

@ayumi ayumi merged commit 9af7f0c into master Nov 2, 2017
@ayumi ayumi deleted the muon-issue-374 branch November 2, 2017 23:58
ayumi added a commit that referenced this pull request Nov 3, 2017
use `CHROME_USER_DATA_DIR` to set/override the user data dir in tests
ayumi added a commit that referenced this pull request Nov 3, 2017
use `CHROME_USER_DATA_DIR` to set/override the user data dir in tests
ayumi added a commit that referenced this pull request Nov 3, 2017
use `CHROME_USER_DATA_DIR` to set/override the user data dir in tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants