Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes bookmark toolbar move #12496

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 4, 2018

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Resolves #12484

Auditors:

Test Plan: defined in #12484

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Resolves brave#12484

Auditors:

Test Plan:
@NejcZdovc NejcZdovc added this to the 0.20.x (Beta Channel) milestone Jan 4, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 4, 2018
@codecov-io
Copy link

codecov-io commented Jan 4, 2018

Codecov Report

Merging #12496 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #12496      +/-   ##
==========================================
+ Coverage   55.91%   55.91%   +<.01%     
==========================================
  Files         278      278              
  Lines       26975    26980       +5     
  Branches     4363     4363              
==========================================
+ Hits        15082    15086       +4     
- Misses      11893    11894       +1
Flag Coverage Δ
#unittest 55.91% <100%> (ø) ⬆️
Impacted Files Coverage Δ
app/browser/reducers/bookmarksReducer.js 96.92% <100%> (-0.7%) ⬇️
app/browser/reducers/bookmarkFoldersReducer.js 100% <100%> (ø) ⬆️

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great- change looks good 😄 👍

@bsclifton bsclifton merged commit bd129e3 into brave:master Jan 4, 2018
bsclifton added a commit that referenced this pull request Jan 4, 2018
bsclifton added a commit that referenced this pull request Jan 4, 2018
@bsclifton
Copy link
Member

master bd129e3
0.21.x fbb07aa
0.20.x 21fceb5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants