This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixes qr code when it is new #12593
Merged
Fixes qr code when it is new #12593
+53
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12593 +/- ##
=========================================
+ Coverage 56.08% 56.19% +0.1%
=========================================
Files 278 278
Lines 27078 27090 +12
Branches 4385 4387 +2
=========================================
+ Hits 15187 15223 +36
+ Misses 11891 11867 -24
|
NejcZdovc
force-pushed
the
hotfix/#12592-delete
branch
from
8d04baa
to
44e2ddd
Compare
bsclifton
reviewed
Jan 11, 2018
app/browser/api/ledger.js
Outdated
| const newAddress = result.getIn(['properties', 'wallet', 'addresses', 'BAT']) | ||
| const oldAddress = ledgerState.getInfoProps(state).getIn(['addresses', 'BAT']) | ||
|
|
||
| console.log(newAddress, oldAddress) |
There was a problem hiding this comment.
whoops- looks like you left a console log in there 😄
bsclifton
previously approved these changes
Jan 11, 2018
NejcZdovc
force-pushed
the
hotfix/#12592-delete
branch
from
44e2ddd
to
5a49b57
Compare
Resolves brave#12592 Auditors: Test Plan:
NejcZdovc
force-pushed
the
hotfix/#12592-delete
branch
from
5a49b57
to
25fec63
Compare
bsclifton
added a commit
that referenced
this pull request
Jan 11, 2018
Fixes qr code when it is new
bsclifton
added a commit
that referenced
this pull request
Jan 11, 2018
Fixes qr code when it is new
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #12592
Auditors:
Test Plan: defined in #12592
Reviewer Checklist:
Tests