Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix some error branches in tor controller logic. #14675

Merged
merged 2 commits into from
Jul 10, 2018
Merged

Fix some error branches in tor controller logic. #14675

merged 2 commits into from
Jul 10, 2018

Commits on Jul 6, 2018

  1. TorControl.close() n'existe pas. Use TorControl.destroy(). 

    fix #14630 (comment)
    @riastradh-brave
    riastradh-brave committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    0dba2d1 View commit details
    Browse the repository at this point in the history

  2. Assert that we've closed only on the next event loop iteration. 

    The event callbacks may not fire immediately.  We may have to wait
for the readable or writable to notice that they are closed.

It may be that process.nextTick is enough for this, but setImmediate
shouldn't hurt and gives us more time for I/O to happen.

fix #14360

Auditors: @diracdeltas @bsclifton

Test Plan:
    @riastradh-brave
    riastradh-brave committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    f0519b0 View commit details
    Browse the repository at this point in the history