Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix/scrolling vertically nav button bug issue #14785 #14815

Closed
wants to merge 1 commit into from

Conversation

joelwass
Copy link

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Check out issue #14785 for a description of the issue.

The problem was we were never resetting the isSwipeOnRightEdge or isSwipeOnLeftEdge values once they were set to true. So once the 'seal was broken' per se, these values were never both false anymore.

Here are associated gifs of before the fix and after.

Before fix:

bug

After fix:

fix1

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton added this to the Completed work milestone Jul 26, 2018
@darkdh
Copy link
Member

darkdh commented Aug 30, 2018

superseded by 69851d1

@darkdh darkdh closed this Aug 30, 2018
@bsclifton bsclifton removed this from the Completed work milestone Aug 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants