This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix/scrolling vertically nav button bug issue #14785 #14815
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Check out issue #14785 for a description of the issue.
The problem was we were never resetting the
isSwipeOnRightEdge
orisSwipeOnLeftEdge
values once they were set to true. So once the 'seal was broken' per se, these values were never both false anymore.Here are associated gifs of before the fix and after.
Before fix:
After fix:
Reviewer Checklist:
Tests