Add Payment History dialog to Payments Tab (issue #2994) #3473
Conversation
- Displays a table of user payment history (Each row represents a batched payout to multiple publishers sometimes called a `reconciliation` or `transaction` elsewhere) - 3 columns are shown for each payment: `Date`, `Total Amount`, & `Receipt Link` - Data comes from `transactions` array in `ledgerData` obj in UI (same as `ledgerInfo` in `browser-laptop/app/ledger.js`) - Next payment date in footer comes from `ledgerData.reconcileStamp` - fix awkward alignment of `Account Balance`, `Monthly Budget` columns, and `View Payment History` button in Payments Tab impls issue #2994
- Remove "Receipt Link" column from this PR - Resize modal and remaining columns
|
So auditors/reviewers get credit for the help in previous PR, here's a summary of the review feedback incorporated into this: Restyle "View Payment History" button Replace "View Payment History" literal with l10nId "viewPaymentHistory" "View Payment History" Button should not display if no wallet or no transactions Payment History footer should be empty if PaymentHistoryRow uses historical exchange rate from new Replace Payment History Footer text with data-l10n-id "paymentHistoryFooterText" PaymentHistoryRow uses Remove unnecessary line Fix "View Payment History" styling
Payment History dialog cleanup
Payments Tab styling fixes
|
|
Great work, thanks again! |
This pull request adds a Payment History dialog to the Payments Tab.
This is the result of rebasing the work in PR #3391 , so some detailed code review is available there.
Detailed discussions and @bradleyrichter's original mockup can be found in issue #2994 (see mockup at #2994 (comment)).
auditors: @diracdeltas @mrose17