This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Updates to help Windows developers #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3548 Accompanied by a new wiki entry: https://github.com/brave/browser-laptop/wiki/Building-on-Windows Powershell scripts for: - automating the fix needed on Windows w/ VS2015 SP3 to resolve the following issue: "error C2373: '__pfnDliNotifyHook2': redefinition; different type modifiers" - automating cleanup/re-initialization needed for fresh npm install - fixing electron on initial Windows run Added npm tasks for executing the above scripts and updated the README.md Auditors: @bbondy @bridiver @aekeus
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3548
Accompanied by a new wiki entry:
https://github.com/brave/browser-laptop/wiki/Building-on-Windows
Powershell scripts for:
"error C2373: '__pfnDliNotifyHook2': redefinition; different type modifiers"
Added npm tasks for executing the above scripts and updated the README.md
Auditors: @bbondy @bridiver @aekeus