This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
serialize app state saves #3632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not really sure what to do for a test plan here because the issue is hard to replicate |
|
test plan wise just verify it doesn't regress anything in saving / loading state. |
|
I tested periodic saves and save on quit. Should also probably test save on upgrade, but there's no reason that would be different than save on quit. I'm going to try setting the periodic timer to a very short interval to force some overlap |
|
set periodic save delay to 1ms and verified that each save/rename block happened sequentially |
| @@ -63,6 +63,7 @@ const flash = require('../js/flash') | |||
| const contentSettings = require('../js/state/contentSettings') | |||
| const privacy = require('../js/state/privacy') | |||
| const basicAuth = require('./browser/basicAuth') | |||
| const async = require('async') | |||
There was a problem hiding this comment.
It's better to require only async/queue so it doesn't pull in everything, pls do in a follow up, I won't block merging this though on it.
|
++ |
This was referenced Sep 4, 2016
This was referenced Sep 5, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.fixes #3543
cc @BrendanEich
There is still an issue with
initiateSessionStateSavebecause it's possible for the calls to overlap and potentially callsaveIfAllCollectedbefore getting state from all the windows. This is possible because it only checks the count and doesn't check to make sure it has state for each active window id.