This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Bitcoin exchange extravaganza #3824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoIP is done without any interaction-with/reporting-to brave software exchange information is downloaded for all country codes from the ledger
| @@ -435,8 +435,14 @@ WindowStore | |||
| } | |||
| }, | |||
| hasBitcoinHandler: boolean, // brave browser has a `bitcoin:` URI handler | |||
| paymentIMG: string, // the QR code equivalent of `paymentURL` expressed as "data:image/...;base64,..." | |||
| error: { // non-null if the last updateLedgerInfo happened concurrently with an error | |||
| countryCode: // ISO3166 2-letter code for country of browser's location | |||
|
please squash commits |
| @@ -32,6 +32,7 @@ const session = electron.session | |||
| const acorn = require('acorn') | |||
| const ledgerBalance = require('ledger-balance') | |||
| const ledgerClient = require('ledger-client') | |||
| const ledgerGeoIP = require('ledger-geoip') | |||
There was a problem hiding this comment.
please remove all providers in https://github.com/brave/ledger-geoip/blob/master/index.js that do not offer HTTPS
|
OBE'd by #3831 |
This was referenced Sep 10, 2016
|
Please add QA steps or label no-qa-needed as appropriate. Thanks! |
This was referenced Sep 14, 2016
|
bump for QA steps |
|
Steps to QA:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
report
ledgerInfo.countryCodeandledgerInfo.exchangeInfofor a new "Add Funds..." dialog.auditor: @diracdeltas